netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: netdev@vger.kernel.org
Cc: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org,
	pabeni@redhat.com, kuba@kernel.org,
	Pavel Begunkov <asml.silence@gmail.com>
Subject: [PATCH net-next v4 0/2] optimise local CPU skb_attempt_defer_free
Date: Wed, 10 Apr 2024 02:28:08 +0100	[thread overview]
Message-ID: <cover.1712711977.git.asml.silence@gmail.com> (raw)

Optimise the case when an skb comes to skb_attempt_defer_free()
on the same CPU it was allocated on. The patch 1 enables skb caches
and gives frags a chance to hit the page pool's fast path.
CPU bound benchmarking with perfect skb_attempt_defer_free()
gives around 1% of extra throughput.

v4: SKB_DROP_REASON_NOT_SPECIFIED -> SKB_CONSUMED
v3: rebased, no changes otherwise
v2: pass @napi_safe=true by using __napi_kfree_skb()

Pavel Begunkov (2):
  net: cache for same cpu skb_attempt_defer_free
  net: use SKB_CONSUMED in skb_attempt_defer_free()

 net/core/skbuff.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

-- 
2.44.0


             reply	other threads:[~2024-04-10  1:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10  1:28 Pavel Begunkov [this message]
2024-04-10  1:28 ` [PATCH net-next v4 1/2] net: cache for same cpu skb_attempt_defer_free Pavel Begunkov
2024-04-10 18:47   ` Eric Dumazet
2024-04-11  2:54   ` Jason Xing
2024-04-10  1:28 ` [PATCH net-next v4 2/2] net: use SKB_CONSUMED in skb_attempt_defer_free() Pavel Begunkov
2024-04-10 18:47   ` Eric Dumazet
2024-04-11  2:30 ` [PATCH net-next v4 0/2] optimise local CPU skb_attempt_defer_free patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1712711977.git.asml.silence@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).