From: <edward.cree@amd.com>
To: <linux-net-drivers@amd.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <edumazet@google.com>, <pabeni@redhat.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>, <netdev@vger.kernel.org>,
<habetsm.xilinx@gmail.com>, <jacob.e.keller@intel.com>
Subject: [RFC PATCH v3 net-next 0/7] sfc: per-queue stats
Date: Wed, 18 Sep 2024 17:14:22 +0100 [thread overview]
Message-ID: <cover.1726593632.git.ecree.xilinx@gmail.com> (raw)
From: Edward Cree <ecree.xilinx@gmail.com>
This series implements the netdev_stat_ops interface for per-queue
statistics in the sfc driver, partly using existing counters that
were originally added for ethtool -S output.
Changed in v3:
* make TX stats count completions rather than enqueues
* add new patch #4 to account for XDP TX separately from netdev
traffic and include it in base_stats
* move the tx_queue->old_* members out of the fastpath cachelines
* note on patch #6 that our hw_gso stats still count enqueues
* RFC since net-next is closed right now
Changed in v2:
* exclude (dedicated) XDP TXQ stats from per-queue TX stats
* explain patch #3 better
Edward Cree (7):
sfc: remove obsolete counters from struct efx_channel
sfc: implement basic per-queue stats
sfc: add n_rx_overlength to ethtool stats
sfc: account XDP TXes in netdev base stats
sfc: implement per-queue rx drop and overrun stats
sfc: implement per-queue TSO (hw_gso) stats
sfc: add per-queue RX bytes stats
drivers/net/ethernet/sfc/ef100_rx.c | 5 +-
drivers/net/ethernet/sfc/efx.c | 109 ++++++++++++++++++++++
drivers/net/ethernet/sfc/efx_channels.c | 6 ++
drivers/net/ethernet/sfc/efx_channels.h | 7 ++
drivers/net/ethernet/sfc/ethtool_common.c | 3 +-
drivers/net/ethernet/sfc/net_driver.h | 47 +++++++++-
drivers/net/ethernet/sfc/rx.c | 5 +-
drivers/net/ethernet/sfc/rx_common.c | 3 +
drivers/net/ethernet/sfc/tx.c | 6 +-
drivers/net/ethernet/sfc/tx_common.c | 33 +++++--
drivers/net/ethernet/sfc/tx_common.h | 4 +-
11 files changed, 210 insertions(+), 18 deletions(-)
next reply other threads:[~2024-09-18 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 16:14 edward.cree [this message]
2024-09-18 16:14 ` [RFC PATCH v3 net-next 1/7] sfc: remove obsolete counters from struct efx_channel edward.cree
2024-09-18 16:14 ` [RFC PATCH v3 net-next 2/7] sfc: implement basic per-queue stats edward.cree
2024-09-18 16:14 ` [RFC PATCH v3 net-next 3/7] sfc: add n_rx_overlength to ethtool stats edward.cree
2024-09-18 16:14 ` [RFC PATCH v3 net-next 4/7] sfc: account XDP TXes in netdev base stats edward.cree
2024-09-18 16:14 ` [RFC PATCH v3 net-next 5/7] sfc: implement per-queue rx drop and overrun stats edward.cree
2024-09-18 16:14 ` [RFC PATCH v3 net-next 6/7] sfc: implement per-queue TSO (hw_gso) stats edward.cree
2024-09-18 16:14 ` [RFC PATCH v3 net-next 7/7] sfc: add per-queue RX bytes stats edward.cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1726593632.git.ecree.xilinx@gmail.com \
--to=edward.cree@amd.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).