netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gur Stavi <gur.stavi@huawei.com>
To: Gur Stavi <gur.stavi@huawei.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH net-next v01 0/4] net: af_packet: allow joining a fanout when link is down
Date: Mon, 7 Oct 2024 15:40:23 +0300	[thread overview]
Message-ID: <cover.1728303615.git.gur.stavi@huawei.com> (raw)

PACKET socket can retain its fanout membership through link down and up
and (obviously) leave a fanout while it is not RUNNING (link down).
However, socket was forbidden from joining a fanout while it was not
RUNNING.

This patch allows PACKET socket to join a fanout while not RUNNING.
Selftest psock_fanout is extended to test this scenario.
This is the only test that was performed.

This scenario was identified while studying DPDK pmd_af_packet_drv.
Since sockets are only created during initialization, there is no reason
to fail the initialization if a single link is temporarily down.

I hope it is not considered as breaking user space and that applications
are not designed to expect this failure.

Gur Stavi (4):
  af_packet: allow fanout_add when socket is not RUNNING
  selftests: net/psock_fanout: add loopback up/down toggle facility
  selftests: net/psock_fanout: restore loopback up/down state on exit
  selftests: net/psock_fanout: socket joins fanout when link is down

 net/packet/af_packet.c                     |  10 +-
 tools/testing/selftests/net/psock_fanout.c | 124 ++++++++++++++-------
 2 files changed, 90 insertions(+), 44 deletions(-)


base-commit: c824deb1a89755f70156b5cdaf569fca80698719
-- 
2.45.2


             reply	other threads:[~2024-10-07 12:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07 12:40 Gur Stavi [this message]
2024-10-07 12:40 ` [PATCH net-next v01 1/4] af_packet: allow fanout_add when socket is not RUNNING Gur Stavi
2024-10-07 22:08   ` Willem de Bruijn
2024-10-07 12:40 ` [PATCH net-next v01 2/4] selftests: net/psock_fanout: add loopback up/down toggle facility Gur Stavi
2024-10-07 12:40 ` [PATCH net-next v01 3/4] selftests: net/psock_fanout: restore loopback up/down state on exit Gur Stavi
2024-10-07 22:15   ` Willem de Bruijn
2024-10-07 12:40 ` [PATCH net-next v01 4/4] selftests: net/psock_fanout: socket joins fanout when link is down Gur Stavi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1728303615.git.gur.stavi@huawei.com \
    --to=gur.stavi@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).