netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gur Stavi <gur.stavi@huawei.com>
To: Gur Stavi <gur.stavi@huawei.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	<linux-kselftest@vger.kernel.org>
Subject: [PATCH net-next v02 0/2] net: af_packet: allow joining a fanout when link is down
Date: Tue, 8 Oct 2024 13:27:57 +0300	[thread overview]
Message-ID: <cover.1728382839.git.gur.stavi@huawei.com> (raw)

PACKET socket can retain its fanout membership through link down and up
and leave a fanout while closed regardless of link state.
However, socket was forbidden from joining a fanout while it was not
RUNNING.

This patch allows PACKET socket to join a fanout while not RUNNING.
Selftest psock_fanout is extended to test this scenario.
This is the only test that was performed.

This scenario was identified while studying DPDK pmd_af_packet_drv.
Since sockets are only created during initialization, there is no reason
to fail the initialization if a single link is temporarily down.

I hope it is not considered as breaking user space and that applications
are not designed to expect this failure.


Changes:

V02:
* psock_fanout: use explicit loopback up/down instead of toggle.
* psock_fanout: don't try to restore loopback state on failure.
* Rephrase commit message about "leaving a fanout".

V01: https://lore.kernel.org/netdev/cover.1728303615.git.gur.stavi@huawei.com/

Gur Stavi (2):
  af_packet: allow fanout_add when socket is not RUNNING
  selftests: net/psock_fanout: socket joins fanout when link is down

 net/packet/af_packet.c                     | 10 +++---
 tools/testing/selftests/net/psock_fanout.c | 42 ++++++++++++++++++++--
 2 files changed, 44 insertions(+), 8 deletions(-)


base-commit: f95b4725e796b12e5f347a0d161e1d3843142aa8
-- 
2.45.2


             reply	other threads:[~2024-10-08 10:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08 10:27 Gur Stavi [this message]
2024-10-08 10:27 ` [PATCH net-next v02 1/2] af_packet: allow fanout_add when socket is not RUNNING Gur Stavi
2024-10-08 14:26   ` Willem de Bruijn
2024-10-09  6:58     ` Gur Stavi
2024-10-09 13:51       ` Willem de Bruijn
2024-10-09 18:03         ` Gur Stavi
2024-10-10  0:30           ` Willem de Bruijn
2024-10-10  7:08             ` Gur Stavi
2024-10-10 14:21               ` Willem de Bruijn
2024-10-10 16:14                 ` Gur Stavi
2024-10-10 22:12                   ` Willem de Bruijn
2024-10-11  5:17                     ` Gur Stavi
2024-10-11 14:24                       ` Willem de Bruijn
2024-10-11  9:02                     ` Gur Stavi
2024-10-11 14:35                       ` Willem de Bruijn
2024-10-11 17:12                         ` Gur Stavi
2024-10-11 19:08                           ` Willem de Bruijn
2024-10-10 11:49             ` Gur Stavi
2024-10-08 10:27 ` [PATCH net-next v02 2/2] selftests: net/psock_fanout: socket joins fanout when link is down Gur Stavi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1728382839.git.gur.stavi@huawei.com \
    --to=gur.stavi@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).