netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Machata <petrm@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>,
	Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
	<mlxsw@nvidia.com>
Subject: [PATCH net-next 0/5] mlxsw: Move Tx header handling to PCI driver
Date: Thu, 16 Jan 2025 17:38:13 +0100	[thread overview]
Message-ID: <cover.1737044384.git.petrm@nvidia.com> (raw)

Amit Cohen writes:

Tx header should be added to all packets transmitted from the CPU to
Spectrum ASICs. Historically, handling this header was added as a driver
function, as Tx header is different between Spectrum and Switch-X.

From May 2021, there is no support for SwitchX-2 ASIC, and all the relevant
code was removed.

For now, there is no justification to handle Tx header as part of
spectrum.c, we can handle this as part of PCI, in skb_transmit().

This change will also be useful when XDP support will be added to mlxsw,
as for XDP_TX and XDP_REDIRECT actions, Tx header should be added before
transmitting the packet.

Patch set overview:
Patches #1-#2 add structure to store Tx header info and initialize it
Patch #3 moves definitions of Tx header fields to txheader.h
Patch #4 moves Tx header handling to PCI driver
Patch #5 removes unnecessary attribute

Amit Cohen (5):
  mlxsw: Add mlxsw_txhdr_info structure
  mlxsw: Initialize txhdr_info according to PTP operations
  mlxsw: Define Tx header fields in txheader.h
  mlxsw: Move Tx header handling to PCI driver
  mlxsw: Do not store Tx header length as driver parameter

 drivers/net/ethernet/mellanox/mlxsw/core.c    |  21 +-
 drivers/net/ethernet/mellanox/mlxsw/core.h    |  13 +-
 drivers/net/ethernet/mellanox/mlxsw/i2c.c     |   2 +-
 drivers/net/ethernet/mellanox/mlxsw/pci.c     |  44 +++-
 .../net/ethernet/mellanox/mlxsw/spectrum.c    | 209 ++++--------------
 .../net/ethernet/mellanox/mlxsw/spectrum.h    |  11 +-
 .../ethernet/mellanox/mlxsw/spectrum_ptp.c    |  44 +---
 .../ethernet/mellanox/mlxsw/spectrum_ptp.h    |  28 ---
 .../net/ethernet/mellanox/mlxsw/txheader.h    |  63 ++++++
 9 files changed, 176 insertions(+), 259 deletions(-)

-- 
2.47.0


             reply	other threads:[~2025-01-16 16:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 16:38 Petr Machata [this message]
2025-01-16 16:38 ` [PATCH net-next 1/5] mlxsw: Add mlxsw_txhdr_info structure Petr Machata
2025-01-16 16:38 ` [PATCH net-next 2/5] mlxsw: Initialize txhdr_info according to PTP operations Petr Machata
2025-01-16 16:38 ` [PATCH net-next 3/5] mlxsw: Define Tx header fields in txheader.h Petr Machata
2025-01-16 16:38 ` [PATCH net-next 4/5] mlxsw: Move Tx header handling to PCI driver Petr Machata
2025-01-17 11:36   ` Przemek Kitszel
2025-01-16 16:38 ` [PATCH net-next 5/5] mlxsw: Do not store Tx header length as driver parameter Petr Machata
2025-01-17 11:37 ` [PATCH net-next 0/5] mlxsw: Move Tx header handling to PCI driver Przemek Kitszel
2025-01-17 13:12   ` Petr Machata
2025-01-19  1:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1737044384.git.petrm@nvidia.com \
    --to=petrm@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).