From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: "Message-ID :" <cover.1752076293.git.mchehab+huawei@kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Akira Yokosawa <akiyks@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Ignacio Encinas Rubio <ignacio@iencinas.com>,
Marco Elver <elver@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Donald Hunter <donald.hunter@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Jan Stancek <jstancek@redhat.com>,
Paolo Abeni <pabeni@redhat.com>,
Ruben Wauters <rubenru09@aol.com>,
joel@joelfernandes.org, linux-kernel-mentees@lists.linux.dev,
lkmm@lists.linux.dev, netdev@vger.kernel.org,
peterz@infradead.org, stern@rowland.harvard.edu,
Breno Leitao <leitao@debian.org>,
Randy Dunlap <rdunlap@infradead.org>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>
Subject: [PATCH v10 00/14] Don't generate netlink .rst files inside $(srctree)
Date: Mon, 28 Jul 2025 18:01:53 +0200 [thread overview]
Message-ID: <cover.1753718185.git.mchehab+huawei@kernel.org> (raw)
Hi Jon,
That's the v10 version of the parser-yaml series, addressing a couple of
issues raised by Donald.
It should apply cleanly on the top of docs-next, as I just rebased on
the top of docs/docs-next.
Please merge it via your tree, as I have another patch series that will
depend on this one.
-
As discussed at:
https://lore.kernel.org/all/20250610101331.62ba466f@foz.lan/
changeset f061c9f7d058 ("Documentation: Document each netlink family")
added a logic which generates *.rst files inside $(srctree). This is bad
when O=<BUILDDIR> is used.
A recent change renamed the yaml files used by Netlink, revealing a bad
side effect: as "make cleandocs" don't clean the produced files and symbols
appear duplicated for people that don't build the kernel from scratch.
This series adds an yaml parser extension and uses an index file with glob for
*. We opted to write such extension in a way that no actual yaml conversion
code is inside it. This makes it flexible enough to handle other types of yaml
files in the future. The actual yaml conversion logic were placed at
netlink_yml_parser.py.
As requested by YNL maintainers, this version has netlink_yml_parser.py
inside tools/net/ynl/pyynl/ directory. I don't like mixing libraries with
binaries, nor to have Python libraries spread all over the Kernel. IMO,
the best is to put all of them on a common place (scripts/lib, python/lib,
lib/python, ...) but, as this can be solved later, for now let's keep it this
way.
---
v10:
- added a R-B from Donald on patch 5;
- added an extra patch fixing issues with line numbers. I opted to
make it a separate patch, as this was not a trivial fix, and
I wanted to have it documented why the original way doesn't
work, as this information can be useful in the future.
v9:
- did some cleanups due to changes caused by rebases;
- added some reviewed-by/reported-by/tested-by tags;
- addressed some pylint problems at the line numbering patch.
v8:
- minor fixes based on Donald's feedback;
- removed unrelated patches.
v7:
- Added a patch to cleanup conf.py and address coding style issues;
- Added a docutils version check logic to detect known issues when
building the docs with too old or too new docutils version. The
actuall min/max vesion depends on Sphinx version.
v6:
- YNL doc parser is now at tools/net/ynl/pyynl/lib/doc_generator.py;
- two patches got merged;
- added instructions to test docs with Sphinx 3.4.3 (minimal supported
version);
- minor fixes.
v5:
- some patch reorg;
- netlink_yml_parser.py is now together with ynl tools;
- minor fixes.
v4:
- Renamed the YNL parser class;
- some minor patch cleanups and merges;
- added an extra patch to fix a insert_pattern/exclude_pattern logic when
SPHINXDIRS is used.
v3:
- Two series got merged altogether:
- https://lore.kernel.org/linux-doc/cover.1749723671.git.mchehab+huawei@kernel.org/T/#t
- https://lore.kernel.org/linux-doc/cover.1749735022.git.mchehab+huawei@kernel.org
- Added an extra patch to update MAINTAINERS to point to YNL library
- Added a (somewhat unrelated) patch that remove warnings check when
running "make cleandocs".
Mauro Carvalho Chehab (14):
docs: netlink: netlink-raw.rst: use :ref: instead of :doc:
tools: ynl_gen_rst.py: Split library from command line tool
docs: netlink: index.rst: add a netlink index file
tools: ynl_gen_rst.py: cleanup coding style
docs: sphinx: add a parser for yaml files for Netlink specs
docs: use parser_yaml extension to handle Netlink specs
docs: uapi: netlink: update netlink specs link
tools: ynl_gen_rst.py: drop support for generating index files
docs: netlink: remove obsolete .gitignore from unused directory
MAINTAINERS: add netlink_yml_parser.py to linux-doc
tools: netlink_yml_parser.py: add line numbers to parsed data
docs: parser_yaml.py: add support for line numbers from the parser
docs: parser_yaml.py: fix backward compatibility with old docutils
sphinx: parser_yaml.py: fix line numbers information
Documentation/Makefile | 17 -
Documentation/conf.py | 20 +-
Documentation/netlink/specs/index.rst | 13 +
Documentation/networking/index.rst | 2 +-
.../networking/netlink_spec/.gitignore | 1 -
.../networking/netlink_spec/readme.txt | 4 -
Documentation/sphinx/parser_yaml.py | 123 ++++++
Documentation/userspace-api/netlink/index.rst | 2 +-
.../userspace-api/netlink/netlink-raw.rst | 6 +-
Documentation/userspace-api/netlink/specs.rst | 2 +-
MAINTAINERS | 1 +
tools/net/ynl/pyynl/lib/__init__.py | 2 +
tools/net/ynl/pyynl/lib/doc_generator.py | 398 ++++++++++++++++++
tools/net/ynl/pyynl/ynl_gen_rst.py | 384 +----------------
14 files changed, 565 insertions(+), 410 deletions(-)
create mode 100644 Documentation/netlink/specs/index.rst
delete mode 100644 Documentation/networking/netlink_spec/.gitignore
delete mode 100644 Documentation/networking/netlink_spec/readme.txt
create mode 100755 Documentation/sphinx/parser_yaml.py
create mode 100644 tools/net/ynl/pyynl/lib/doc_generator.py
--
2.49.0
next reply other threads:[~2025-07-28 16:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 16:01 Mauro Carvalho Chehab [this message]
2025-07-28 16:01 ` [PATCH v10 01/14] docs: netlink: netlink-raw.rst: use :ref: instead of :doc: Mauro Carvalho Chehab
2025-07-28 16:01 ` [PATCH v10 02/14] tools: ynl_gen_rst.py: Split library from command line tool Mauro Carvalho Chehab
2025-07-28 16:01 ` [PATCH v10 03/14] docs: netlink: index.rst: add a netlink index file Mauro Carvalho Chehab
2025-07-28 16:01 ` [PATCH v10 04/14] tools: ynl_gen_rst.py: cleanup coding style Mauro Carvalho Chehab
2025-07-28 16:01 ` [PATCH v10 05/14] docs: sphinx: add a parser for yaml files for Netlink specs Mauro Carvalho Chehab
2025-07-28 16:01 ` [PATCH v10 06/14] docs: use parser_yaml extension to handle " Mauro Carvalho Chehab
2025-08-28 16:50 ` Kory Maincent
2025-08-28 17:02 ` Kory Maincent
2025-07-28 16:02 ` [PATCH v10 07/14] docs: uapi: netlink: update netlink specs link Mauro Carvalho Chehab
2025-07-28 16:02 ` [PATCH v10 08/14] tools: ynl_gen_rst.py: drop support for generating index files Mauro Carvalho Chehab
2025-07-28 16:02 ` [PATCH v10 09/14] docs: netlink: remove obsolete .gitignore from unused directory Mauro Carvalho Chehab
2025-07-28 16:02 ` [PATCH v10 10/14] MAINTAINERS: add netlink_yml_parser.py to linux-doc Mauro Carvalho Chehab
2025-07-28 16:02 ` [PATCH v10 11/14] tools: netlink_yml_parser.py: add line numbers to parsed data Mauro Carvalho Chehab
2025-07-28 16:02 ` [PATCH v10 12/14] docs: parser_yaml.py: add support for line numbers from the parser Mauro Carvalho Chehab
2025-07-28 16:02 ` [PATCH v10 13/14] docs: parser_yaml.py: fix backward compatibility with old docutils Mauro Carvalho Chehab
2025-07-28 16:02 ` [PATCH v10 14/14] sphinx: parser_yaml.py: fix line numbers information Mauro Carvalho Chehab
2025-08-11 17:28 ` [PATCH v10 00/14] Don't generate netlink .rst files inside $(srctree) Jonathan Corbet
2025-08-12 0:56 ` Jakub Kicinski
2025-08-12 9:29 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1753718185.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=cover.1752076293.git.mchehab+huawei@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=horms@kernel.org \
--cc=ignacio@iencinas.com \
--cc=joel@joelfernandes.org \
--cc=jstancek@redhat.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rubenru09@aol.com \
--cc=skhan@linuxfoundation.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).