From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EEFE307491; Wed, 15 Oct 2025 22:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760567530; cv=none; b=GRafKLyV6Q2ANvuqs3dysPWr8qpJbaNcpkAgR0ncbSerr/qGgFIR/PHbJrTbS0qLwYG1EATNNyhY/0WCTDGt7Vo+7hpbn8NYvwmvi4YrxtRRaRXHv0ma7zateu4KXkMWWjSvtr/3pZ76ylVR+//YidElsP55+/1KZkHsIantXw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760567530; c=relaxed/simple; bh=Fk/NUdr0xb3/gpiLV3dXIsZqBbYeopnPG3AceI+haqo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=sgzN2k4WRbgON8cAtSgB6lFlV1xhMxgkUXB4n3NScMhrdjAEfUXBOAU8xo8RvCRT9B4TnbruXJRdRUyv2JJ9gvNZCvi2aGdrqyyZGbh4GYa2F+tdk9/UZvxbE8e5tjbv4ozlS5sE/lFw/kNw2yIL3e7lNoa2puDSnVmYUudd17w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1v9A2I-000000006Tv-2P8a; Wed, 15 Oct 2025 22:31:58 +0000 Date: Wed, 15 Oct 2025 23:31:51 +0100 From: Daniel Golle To: Hauke Mehrtens , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andreas Schirm , Lukas Stockmann , Alexander Sverdlin , Peter Christen , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: [PATCH net-next 00/11] net: dsa: lantiq_gswip: clean up and improve VLAN handling Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi all, This series was developed by Vladimir Oltean to improve and clean up the VLAN handling logic in the Lantiq GSWIP DSA driver. As Vladimir currently doesn't have the availability to take care of the submission process, we agreed that I would send the patches on his behalf. The series focuses on consolidating the VLAN management paths for both VLAN-unaware and VLAN-aware bridges, simplifying internal logic, and removing legacy or redundant code. It also fixes a number of subtle inconsistencies regarding VLAN ID 0 handling, bridge FDB entries, and brings the driver into shape to permit dynamic changes to the VLAN filtering state. Notable changes include: - Support for bridge FDB entries on the CPU port - Consolidation of gswip_vlan_add_unaware() and gswip_vlan_add_aware() into a unified implementation - Removal of legacy VLAN configuration options and redundant assignments - Improved handling of VLAN ID 0 and PVID behavior - Better validation and error reporting in VLAN removal paths - Support for dynamic VLAN filtering configuration changes Overall, this refactor improves readability and maintainability of the Lantiq GSWIP DSA driver. It also results in all local-termination.sh tests now passing, and slightly improves the results of bridge-vlan-{un,}aware.sh. All patches have been authored by Vladimir Oltean; a small unintended functional change in patch "net: dsa: lantiq_gswip: merge gswip_vlan_add_unaware() and gswip_vlan_add_aware()" has been ironed out and some of the commit descriptions were improved by me, apart from that I'm only handling the submission and will help with follow-up discussions or review feedback as needed. Despite the fact that some changes here do actually fix things (in the sense that selftests which would previously FAIL now PASS) we decided that it would be the best for this series of patches to go via net-next. If requested some of it can still be ported to stable kernels later on. Vladimir Oltean (11): net: dsa: lantiq_gswip: support bridge FDB entries on the CPU port net: dsa: lantiq_gswip: define VLAN ID 0 constant net: dsa: lantiq_gswip: remove duplicate assignment to vlan_mapping.val[0] net: dsa: lantiq_gswip: merge gswip_vlan_add_unaware() and gswip_vlan_add_aware() net: dsa: lantiq_gswip: remove legacy configure_vlan_while_not_filtering option net: dsa: lantiq_gswip: permit dynamic changes to VLAN filtering state net: dsa: lantiq_gswip: disallow changes to privately set up VID 0 net: dsa: lantiq_gswip: remove vlan_aware and pvid arguments from gswip_vlan_remove() net: dsa: lantiq_gswip: put a more descriptive error print in gswip_vlan_remove() net: dsa: lantiq_gswip: drop untagged on VLAN-aware bridge ports with no PVID net: dsa: lantiq_gswip: treat VID 0 like the PVID drivers/net/dsa/lantiq/lantiq_gswip.c | 224 ++++++++++++-------------- drivers/net/dsa/lantiq/lantiq_gswip.h | 7 +- 2 files changed, 107 insertions(+), 124 deletions(-) -- 2.51.0