From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout10.his.huawei.com (canpmsgout10.his.huawei.com [113.46.200.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3BCA548EE; Mon, 26 Jan 2026 01:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769389599; cv=none; b=MkcuvbjEVfXsYj5ds9STxJkFqNb8JgUb6LrO6vh39mbnpfW2Hvcvkn/LBDKshOIwa6GhUxNRSgAVFVxPwwf4vtrnM3SZdyQbpZYF5XfNID2ql7CDUkN3bmZPDBjb1wa0roFgoBHPRhFfGplIlNX5gmOD10AyyBYqfIFPQ/LojRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769389599; c=relaxed/simple; bh=FyrJO934c2Q08VFZw98/QGu7W1xJURNsMAM6qBnp2aE=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=svVOgB2x+knTRIy+6S6lkz3E0e0aFVwjO0trVXtXJjF/u5EwCJTmeMTM3cpC+CFQrrnsSZO+4Cgt4P+ib9CD1qrBmTCykqLa4BGyVg5FIgZIawkYHyoiG8P9Sf23UgeW7ldTNWgxfae78gmuHSWUwwwqLttZxQwi3ClNldhqnSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=5/H4LYxe; arc=none smtp.client-ip=113.46.200.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="5/H4LYxe" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=6kk/V2kSb+hk1d/bnoCL/WTzwRbODiqZx5XFRSsUATs=; b=5/H4LYxeBe2fLH5C07zuYFwZE3RTeVY7U9kcy9Yi9ja6DRwmf/SJr2ZEWHpaEbpZZZR+gMGhp IKCNyTvBBiDC7L54vknutFrYOZT7eMJW30MTKyV8IdGq1zek5EvCyUWgnY6WsM+uH7v7kYZAeff y4T2xM56x34I5g0NDf6xP2o= Received: from mail.maildlp.com (unknown [172.19.162.92]) by canpmsgout10.his.huawei.com (SkyGuard) with ESMTPS id 4dzqys2YH8z1K9Xq; Mon, 26 Jan 2026 09:03:01 +0800 (CST) Received: from kwepemf100013.china.huawei.com (unknown [7.202.181.12]) by mail.maildlp.com (Postfix) with ESMTPS id D80FD40568; Mon, 26 Jan 2026 09:06:25 +0800 (CST) Received: from DESKTOP-62GVMTR.china.huawei.com (10.174.188.120) by kwepemf100013.china.huawei.com (7.202.181.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Mon, 26 Jan 2026 09:06:24 +0800 From: Fan Gong To: Fan Gong , Zhu Yikai , , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn CC: , , luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Luo Yang Subject: [PATCH net-next v02 0/4] net: hinic3: Fix code styles Date: Mon, 26 Jan 2026 09:03:30 +0800 Message-ID: X-Mailer: git-send-email 2.51.0.windows.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemf100013.china.huawei.com (7.202.181.12) This patchset provides 4 code styles fixes: Remove empty lines between error handling. Remove redundant defensive code. Use array_size instead of multiplying. SQ use SQ_CTXT_PREF_CI_HI to improve readability. Thanks, Fan gong Fan Gong (4): hinic3: Fix code Style(remove empty lines between error handling) hinic3: Remove redundant defensive code hinic3: Use array_size instead of multiplying hinic3: RQ use RQ_CTXT_PREF_CI_HI instead of SQ_CTXT_PREF_CI_HI drivers/net/ethernet/huawei/hinic3/hinic3_cmdq.c | 3 --- drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c | 1 - drivers/net/ethernet/huawei/hinic3/hinic3_lld.c | 5 ----- drivers/net/ethernet/huawei/hinic3/hinic3_main.c | 4 ---- drivers/net/ethernet/huawei/hinic3/hinic3_mbox.c | 2 -- drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c | 6 ++++-- drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c | 6 +++++- drivers/net/ethernet/huawei/hinic3/hinic3_tx.c | 7 ------- 8 files changed, 9 insertions(+), 25 deletions(-) base-commit: 4515ec4ad58a37e70a9e1256c0b993958c9b7497 -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout06.his.huawei.com (canpmsgout06.his.huawei.com [113.46.200.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87EEA246BCD; Thu, 5 Mar 2026 14:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.221 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772720536; cv=none; b=D32+QOil8yLI1mptHzpKIn2dYmQLaWfEKSl6/Qm6yT1Ogwm9ZFffIVcOQKMg/pNKvf3bWOh/aMXBWK9tJrl0HtDCqlzWNf1i37UYrH5PeTevKRompwJjrE1DEqgYeI/cUdZHBr04ncuo6sAfgU510LY+92HuL23mSeT80Ya31kY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772720536; c=relaxed/simple; bh=FyrJO934c2Q08VFZw98/QGu7W1xJURNsMAM6qBnp2aE=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=FaQTICyVzgLG7BUkEHY+aIGC6InVMH2c4mR4OXU7LPWmwA2kRkp4MgKhxKmWdR+sB7Cz4iTBvZytcvke326kB3W29/ZMX4p9RyqQfeU6fFzzTaW9CR6GCkUUq2Q4Az0mINZ/6Hd6/ngWITWKMWMoverDQCsPtu/00RFzzZGRQRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=5/H4LYxe; arc=none smtp.client-ip=113.46.200.221 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="5/H4LYxe" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=6kk/V2kSb+hk1d/bnoCL/WTzwRbODiqZx5XFRSsUATs=; b=5/H4LYxeBe2fLH5C07zuYFwZE3RTeVY7U9kcy9Yi9ja6DRwmf/SJr2ZEWHpaEbpZZZR+gMGhp IKCNyTvBBiDC7L54vknutFrYOZT7eMJW30MTKyV8IdGq1zek5EvCyUWgnY6WsM+uH7v7kYZAeff y4T2xM56x34I5g0NDf6xP2o= Received: from mail.maildlp.com (unknown [172.19.162.144]) by canpmsgout06.his.huawei.com (SkyGuard) with ESMTPS id 4fRWnm1b6gzRhR1; Thu, 5 Mar 2026 22:17:16 +0800 (CST) Received: from kwepemf100013.china.huawei.com (unknown [7.202.181.12]) by mail.maildlp.com (Postfix) with ESMTPS id 4FE9340538; Thu, 5 Mar 2026 22:22:07 +0800 (CST) Received: from DESKTOP-62GVMTR.china.huawei.com (10.174.189.124) by kwepemf100013.china.huawei.com (7.202.181.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Thu, 5 Mar 2026 22:22:06 +0800 From: Fan Gong To: Fan Gong , Zhu Yikai , , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn CC: , , luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Luo Yang Subject: [PATCH net-next v02 0/4] net: hinic3: Fix code styles Date: Thu, 5 Mar 2026 22:21:57 +0800 Message-ID: X-Mailer: git-send-email 2.51.0.windows.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemf100013.china.huawei.com (7.202.181.12) Message-ID: <20260305142157.H1qZOMxD1BeRs79cqC7e5NJGKiExcHHbAl24Q4bJbkY@z> This patchset provides 4 code styles fixes: Remove empty lines between error handling. Remove redundant defensive code. Use array_size instead of multiplying. SQ use SQ_CTXT_PREF_CI_HI to improve readability. Thanks, Fan gong Fan Gong (4): hinic3: Fix code Style(remove empty lines between error handling) hinic3: Remove redundant defensive code hinic3: Use array_size instead of multiplying hinic3: RQ use RQ_CTXT_PREF_CI_HI instead of SQ_CTXT_PREF_CI_HI drivers/net/ethernet/huawei/hinic3/hinic3_cmdq.c | 3 --- drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c | 1 - drivers/net/ethernet/huawei/hinic3/hinic3_lld.c | 5 ----- drivers/net/ethernet/huawei/hinic3/hinic3_main.c | 4 ---- drivers/net/ethernet/huawei/hinic3/hinic3_mbox.c | 2 -- drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c | 6 ++++-- drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c | 6 +++++- drivers/net/ethernet/huawei/hinic3/hinic3_tx.c | 7 ------- 8 files changed, 9 insertions(+), 25 deletions(-) base-commit: 4515ec4ad58a37e70a9e1256c0b993958c9b7497 -- 2.43.0