From: Antony Antony <antony.antony@secunet.com>
To: Antony Antony <antony.antony@secunet.com>,
Jakub Kicinski <kuba@kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
<netdev@vger.kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Shuah Khan <shuah@kernel.org>, <devel@linux-ipsec.org>,
Tobias Brunner <tobias@strongswan.org>,
Simon Horman <horms@kernel.org>
Subject: [PATCH net-next v4 0/2] icmp: Fix icmp error source address over xfrm tunnel
Date: Wed, 28 Jan 2026 11:19:06 +0100 [thread overview]
Message-ID: <cover.1769595011.git.antony.antony@secunet.com> (raw)
This fix, originally sent to XFRM/IPsec, has been recommended by
Steffen Klassert to submit to the net tree, since it changes ICMP
behavior.
The patch addresses a minor issue related to the IPv4 source address
of ICMP error messages. The bug only occurs when xfrm policies are
configured. It originated from an old 2011 commit:
commit 415b3334a21a ("icmp: Fix regression in nexthop resolution during
replies.")
Submitting to net-next with a selftest.
Antony Antony (2):
icmp: fix ICMP error source address when xfrm policy matches
selftests: net: add ICMP error source address test over xfrm tunnel
net/ipv4/icmp.c | 1 -
tools/testing/selftests/net/Makefile | 1 +
tools/testing/selftests/net/xfrm_state.sh | 578 ++++++++++++++++++++++
3 files changed, 579 insertions(+), 1 deletion(-)
create mode 100755 tools/testing/selftests/net/xfrm_state.sh
---
v1->v2 : add kernel selftest script
v2->v3 : fix test script.
v3->v4 : fix test script based on reviews
- clarify commit message
- Changed subsystem prefix to icmp: since fix is in net/ipv4/icmp.c
-antony
next reply other threads:[~2026-01-28 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 10:19 Antony Antony [this message]
2026-01-28 10:20 ` [PATCH net-next v4 2/2] selftests: net: add ICMP error source address test over xfrm tunnel Antony Antony
2026-01-30 2:43 ` Jakub Kicinski
2026-02-02 12:15 ` [devel-ipsec] " Antony Antony
2026-01-28 10:25 ` [PATCH net-next v4 1/2] icmp: fix ICMP error source address when xfrm policy matches Antony Antony
2026-01-30 2:45 ` Jakub Kicinski
2026-02-02 12:07 ` [devel-ipsec] " Antony Antony
2026-02-02 14:53 ` Paul Wouters
2026-02-02 15:16 ` Tobias Brunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1769595011.git.antony.antony@secunet.com \
--to=antony.antony@secunet.com \
--cc=davem@davemloft.net \
--cc=devel@linux-ipsec.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tobias@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox