From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout01.his.huawei.com (canpmsgout01.his.huawei.com [113.46.200.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 076BB39C65C; Tue, 24 Feb 2026 13:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.216 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771938975; cv=none; b=tThCN9Q7ZghgAIE3ntpROpqER6TsOPfmylh68tn1brzqF/YaEtuFj5hGRYZIJVpCQ289nW6k0dP+p7ni+vTxM3fQrTIE05J4KtnUImzq9FRlCgTDmCM1H13TjgyCFH79r+VOHFa5L0w39ULzBOVzZXksyGQRMitpvMF/lb4M8e4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771938975; c=relaxed/simple; bh=GF/oHl/8hMLdsJmFBHfQUTk9KqyrNTSf61qDfrlAWqk=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=XekFuHGuLkG7xFRTD9SDLt7p1tbsi+QR6hiNsYo60/NARWfRLm80oFqiLHo8aoALWgxyfqStGSIwhC/dLxMZ+H6oyysm9R8z6BkIt1kYJEJ/hKLWulTlB8CFdRrqB5na5qK3rb/2AKfCjxuc6payWEb96JZshR8s99qz5p9CC+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=QKpMSpAI; arc=none smtp.client-ip=113.46.200.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="QKpMSpAI" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=IMiEa0RUKKNBqPTwHrxxYXdut90yci9zePakTv5j+6g=; b=QKpMSpAIVbPsxR2sZZp2mdc/S1BOw/PBnvdgZmpbwUv6aMBExxJnmNgXudjS4orJ2f3gl7bkB 9Le101kmLy54NvdTEamAVtjVFaPIlNpnoyyCXC1abaD58TYezVe79yfLOlyqWx2GeOTdSJYnI2A ViHPeC+kcVz01umL9ahpso4= Received: from mail.maildlp.com (unknown [172.19.163.0]) by canpmsgout01.his.huawei.com (SkyGuard) with ESMTPS id 4fKylh4dh4z1T4Mf; Tue, 24 Feb 2026 21:11:12 +0800 (CST) Received: from kwepemf100013.china.huawei.com (unknown [7.202.181.12]) by mail.maildlp.com (Postfix) with ESMTPS id 471A04056B; Tue, 24 Feb 2026 21:16:03 +0800 (CST) Received: from DESKTOP-62GVMTR.china.huawei.com (10.174.189.124) by kwepemf100013.china.huawei.com (7.202.181.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Tue, 24 Feb 2026 21:16:02 +0800 From: Fan Gong To: Fan Gong , Zhu Yikai , , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn CC: , , luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing Subject: [PATCH net-next v01 00/15] net: hinic3: Fix code styles Date: Tue, 24 Feb 2026 21:15:37 +0800 Message-ID: X-Mailer: git-send-email 2.51.0.windows.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemf100013.china.huawei.com (7.202.181.12) This patchset provides 4 code styles fixes: Remove empty lines between error handling. Remove defensive txq_num check. Use array_size instead of multiplying. SQ use SQ_CTXT_PREF_CI_HI to improve readability. Changes: PATCH V01: https://lore.kernel.org/netdev/cover.1768915707.git.zhuyikai1@h-partners.com/ PATCH V02: https://lore.kernel.org/netdev/cover.1769142701.git.zhuyikai1@h-partners.com/ * Send "Fix netif_queue_set_napi queue_index parameter passing error" to net (Jakub Kicinski) PATCH V03: * Modify commit description to be more accurate and clear (Simon Horman) Fan Gong (15): hinic3: Add command queue detailed-respone interfaces hinic3: Add Command Queue/Async Event Queue/Mailbox dump interfaces hinic3: Add chip_present_flag checks to prevent errors when card is absent hinic3: Add RX GRO and VLAN offload support hinic3: Add msg_send_lock for message sending concurrecy hinic3: Add PF device support and function type validation hinic3: Add PF FLR wait and timeout handling hinic3: Add PF/VF capability parsing and parameter validation hinic3: Add ethtool basic ops hinic3: Add ethtool queue ops hinic3: Add ethtool statistic ops hinic3: Add ethtool coalesce ops hinic3: Add ethtool rss ops hinic3: Add MTU size validation hinic3: Config netdev->watchdog_timeo to set nic tx timeout drivers/net/ethernet/huawei/hinic3/Makefile | 1 + .../net/ethernet/huawei/hinic3/hinic3_cmdq.c | 225 ++- .../net/ethernet/huawei/hinic3/hinic3_cmdq.h | 15 + .../ethernet/huawei/hinic3/hinic3_common.h | 1 + .../net/ethernet/huawei/hinic3/hinic3_csr.h | 2 + .../net/ethernet/huawei/hinic3/hinic3_eqs.c | 67 + .../net/ethernet/huawei/hinic3/hinic3_eqs.h | 6 + .../ethernet/huawei/hinic3/hinic3_ethtool.c | 1217 +++++++++++++++++ .../ethernet/huawei/hinic3/hinic3_hw_cfg.c | 53 +- .../ethernet/huawei/hinic3/hinic3_hw_cfg.h | 8 + .../ethernet/huawei/hinic3/hinic3_hw_comm.c | 65 + .../ethernet/huawei/hinic3/hinic3_hw_comm.h | 2 + .../ethernet/huawei/hinic3/hinic3_hw_intf.h | 25 +- .../net/ethernet/huawei/hinic3/hinic3_hwdev.c | 11 + .../net/ethernet/huawei/hinic3/hinic3_hwdev.h | 1 + .../net/ethernet/huawei/hinic3/hinic3_hwif.c | 31 +- .../net/ethernet/huawei/hinic3/hinic3_irq.c | 3 +- .../net/ethernet/huawei/hinic3/hinic3_lld.c | 1 + .../net/ethernet/huawei/hinic3/hinic3_main.c | 10 + .../net/ethernet/huawei/hinic3/hinic3_mbox.c | 35 +- .../net/ethernet/huawei/hinic3/hinic3_mbox.h | 2 + .../huawei/hinic3/hinic3_mgmt_interface.h | 55 +- .../huawei/hinic3/hinic3_netdev_ops.c | 76 +- .../ethernet/huawei/hinic3/hinic3_nic_cfg.c | 167 +++ .../ethernet/huawei/hinic3/hinic3_nic_cfg.h | 219 +++ .../ethernet/huawei/hinic3/hinic3_nic_dev.h | 30 + .../ethernet/huawei/hinic3/hinic3_nic_io.h | 4 + .../huawei/hinic3/hinic3_pci_id_tbl.h | 1 + .../net/ethernet/huawei/hinic3/hinic3_rss.c | 487 ++++++- .../net/ethernet/huawei/hinic3/hinic3_rss.h | 19 + .../net/ethernet/huawei/hinic3/hinic3_rx.c | 84 +- .../net/ethernet/huawei/hinic3/hinic3_rx.h | 17 + .../net/ethernet/huawei/hinic3/hinic3_tx.c | 72 +- .../net/ethernet/huawei/hinic3/hinic3_tx.h | 2 + 34 files changed, 2985 insertions(+), 29 deletions(-) create mode 100644 drivers/net/ethernet/huawei/hinic3/hinic3_ethtool.c base-commit: f77c7b96014471f2c39823ed9fcb42967e7d9ede -- 2.43.0