[PATCH 0/2] dt-bindings: net: micrel: Fix KSZ8041RNLI dtbs_check warnings

[PATCH 0/2] dt-bindings: net: micrel: Fix KSZ8041RNLI dtbs_check warnings

[Geert Uytterhoeven]

	Hi all,

"make dtbs_check" reports several warnings due to some KSZ8041RNLI PHY
nodes having the "micrel,led-mode" property, while the DT bindings
prohibit this.

Apparently the DT bindings are incorrect, so this patch series fixes
that, after a customary cleanup.

Thanks for your comments!

Geert Uytterhoeven (2):
  dt-bindings: net: micrel: Sort lists
  dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

 Documentation/devicetree/bindings/net/micrel.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.43.0

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/2] dt-bindings: net: micrel: Sort lists

[Geert Uytterhoeven]

Sort lists of PHY models and compatible values alphabetically.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/net/micrel.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
index ecc00169ef805dc2..5d25f0d0a508a6df 100644
--- a/Documentation/devicetree/bindings/net/micrel.yaml
+++ b/Documentation/devicetree/bindings/net/micrel.yaml
@@ -51,9 +51,9 @@ properties:
       bits that are currently supported:
 
       KSZ8001: register 0x1e, bits 15..14
-      KSZ8041: register 0x1e, bits 15..14
       KSZ8021: register 0x1f, bits 5..4
       KSZ8031: register 0x1f, bits 5..4
+      KSZ8041: register 0x1e, bits 15..14
       KSZ8051: register 0x1f, bits 5..4
       KSZ8081: register 0x1f, bits 5..4
       KSZ8091: register 0x1f, bits 5..4
@@ -80,9 +80,9 @@ allOf:
             contains:
               enum:
                 - ethernet-phy-id0022.1510
+                - ethernet-phy-id0022.1550
                 - ethernet-phy-id0022.1555
                 - ethernet-phy-id0022.1556
-                - ethernet-phy-id0022.1550
                 - ethernet-phy-id0022.1560
                 - ethernet-phy-id0022.161a
     then:
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: net: micrel: Sort lists

[Stefan Eichenberger]

On Thu, Mar 12, 2026 at 02:27:35PM +0100, Geert Uytterhoeven wrote:
> Sort lists of PHY models and compatible values alphabetically.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/net/micrel.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
> index ecc00169ef805dc2..5d25f0d0a508a6df 100644
> --- a/Documentation/devicetree/bindings/net/micrel.yaml
> +++ b/Documentation/devicetree/bindings/net/micrel.yaml
> @@ -51,9 +51,9 @@ properties:
>        bits that are currently supported:
>  
>        KSZ8001: register 0x1e, bits 15..14
> -      KSZ8041: register 0x1e, bits 15..14
>        KSZ8021: register 0x1f, bits 5..4
>        KSZ8031: register 0x1f, bits 5..4
> +      KSZ8041: register 0x1e, bits 15..14
>        KSZ8051: register 0x1f, bits 5..4
>        KSZ8081: register 0x1f, bits 5..4
>        KSZ8091: register 0x1f, bits 5..4
> @@ -80,9 +80,9 @@ allOf:
>              contains:
>                enum:
>                  - ethernet-phy-id0022.1510
> +                - ethernet-phy-id0022.1550
>                  - ethernet-phy-id0022.1555
>                  - ethernet-phy-id0022.1556
> -                - ethernet-phy-id0022.1550
>                  - ethernet-phy-id0022.1560
>                  - ethernet-phy-id0022.161a
>      then:

Looks good to me, thanks for the cleanup.

Reviewed-by: Stefan Eichenberger <eichest@gmail.com>

Re: [PATCH 1/2] dt-bindings: net: micrel: Sort lists

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

[Geert Uytterhoeven]

Micrel KSZ8041RNLI supports LED mode, just like KSZ8041.

This fixes (a.o.) the following "make dtbs_check" warning:

    arch/arm/boot/dts/renesas/r8a7791-koelsch.dtb: ethernet-phy@1 (ethernet-phy-id0022.1537): False schema does not allow 1
	    from schema $id: http://devicetree.org/schemas/net/micrel.yaml

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/net/micrel.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
index 5d25f0d0a508a6df..7fb61c78d16cd801 100644
--- a/Documentation/devicetree/bindings/net/micrel.yaml
+++ b/Documentation/devicetree/bindings/net/micrel.yaml
@@ -54,6 +54,7 @@ properties:
       KSZ8021: register 0x1f, bits 5..4
       KSZ8031: register 0x1f, bits 5..4
       KSZ8041: register 0x1e, bits 15..14
+      KSZ8041RLNI: register 0x1e, bits 15..14
       KSZ8051: register 0x1f, bits 5..4
       KSZ8081: register 0x1f, bits 5..4
       KSZ8091: register 0x1f, bits 5..4
@@ -80,6 +81,7 @@ allOf:
             contains:
               enum:
                 - ethernet-phy-id0022.1510
+                - ethernet-phy-id0022.1537
                 - ethernet-phy-id0022.1550
                 - ethernet-phy-id0022.1555
                 - ethernet-phy-id0022.1556
-- 
2.43.0

Re: [PATCH 2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

[Stefan Eichenberger]

On Thu, Mar 12, 2026 at 02:27:36PM +0100, Geert Uytterhoeven wrote:
> Micrel KSZ8041RNLI supports LED mode, just like KSZ8041.
> 
> This fixes (a.o.) the following "make dtbs_check" warning:
> 
>     arch/arm/boot/dts/renesas/r8a7791-koelsch.dtb: ethernet-phy@1 (ethernet-phy-id0022.1537): False schema does not allow 1
> 	    from schema $id: http://devicetree.org/schemas/net/micrel.yaml
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/net/micrel.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
> index 5d25f0d0a508a6df..7fb61c78d16cd801 100644
> --- a/Documentation/devicetree/bindings/net/micrel.yaml
> +++ b/Documentation/devicetree/bindings/net/micrel.yaml
> @@ -54,6 +54,7 @@ properties:
>        KSZ8021: register 0x1f, bits 5..4
>        KSZ8031: register 0x1f, bits 5..4
>        KSZ8041: register 0x1e, bits 15..14
> +      KSZ8041RLNI: register 0x1e, bits 15..14
>        KSZ8051: register 0x1f, bits 5..4
>        KSZ8081: register 0x1f, bits 5..4
>        KSZ8091: register 0x1f, bits 5..4
> @@ -80,6 +81,7 @@ allOf:
>              contains:
>                enum:
>                  - ethernet-phy-id0022.1510
> +                - ethernet-phy-id0022.1537
>                  - ethernet-phy-id0022.1550
>                  - ethernet-phy-id0022.1555
>                  - ethernet-phy-id0022.1556

Looks also good to me, thanks for the fix.

Reviewed-by: Stefan Eichenberger <eichest@gmail.com>

Re: [PATCH 2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

[Jakub Kicinski]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

Micrel KSZ8041RNLI supports LED mode, just like KSZ8041. This fixes (a.o.)
the following "make dtbs_check" warning for the r8a7791-koelsch device tree.

> diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
> --- a/Documentation/devicetree/bindings/net/micrel.yaml
> +++ b/Documentation/devicetree/bindings/net/micrel.yaml
> @@ -54,6 +54,7 @@
>        KSZ8021: register 0x1f, bits 5..4
>        KSZ8031: register 0x1f, bits 5..4
>        KSZ8041: register 0x1e, bits 15..14
> +      KSZ8041RLNI: register 0x1e, bits 15..14
                  ^^^^
This isn't a bug, but there's a typo here. Should this be KSZ8041RNLI
instead of KSZ8041RLNI?

The chip is called KSZ8041RNLI in the commit subject and in the compatible
string definition:

>        KSZ8051: register 0x1f, bits 5..4
>        KSZ8081: register 0x1f, bits 5..4
>        KSZ8091: register 0x1f, bits 5..4

[ ... ]

> @@ -80,6 +81,7 @@
>              contains:
>                enum:
>                  - ethernet-phy-id0022.1510
> +                - ethernet-phy-id0022.1537
>                  - ethernet-phy-id0022.1555
>                  - ethernet-phy-id0022.1556
>                  - ethernet-phy-id0022.1560
-- 
pw-bot: cr

Re: [2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

[Geert Uytterhoeven]

Hi Jakub(ot ;-),

On Sat, 14 Mar 2026 at 03:01, Jakub Kicinski <kuba@kernel.org> wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.
>
> For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
> ---
> dt-bindings: net: micrel: KSZ8041RNLI supports LED mode
>
> Micrel KSZ8041RNLI supports LED mode, just like KSZ8041. This fixes (a.o.)
> the following "make dtbs_check" warning for the r8a7791-koelsch device tree.
>
> > diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
> > --- a/Documentation/devicetree/bindings/net/micrel.yaml
> > +++ b/Documentation/devicetree/bindings/net/micrel.yaml
> > @@ -54,6 +54,7 @@
> >        KSZ8021: register 0x1f, bits 5..4
> >        KSZ8031: register 0x1f, bits 5..4
> >        KSZ8041: register 0x1e, bits 15..14
> > +      KSZ8041RLNI: register 0x1e, bits 15..14
>                   ^^^^
> This isn't a bug, but there's a typo here. Should this be KSZ8041RNLI
> instead of KSZ8041RLNI?

Yes, it is a typo. Shall I send a v2 with this fixed?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [2/2] dt-bindings: net: micrel: KSZ8041RNLI supports LED mode

[Jakub Kicinski]

On Mon, 16 Mar 2026 09:22:19 +0100 Geert Uytterhoeven wrote:
> > > diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
> > > --- a/Documentation/devicetree/bindings/net/micrel.yaml
> > > +++ b/Documentation/devicetree/bindings/net/micrel.yaml
> > > @@ -54,6 +54,7 @@
> > >        KSZ8021: register 0x1f, bits 5..4
> > >        KSZ8031: register 0x1f, bits 5..4
> > >        KSZ8041: register 0x1e, bits 15..14
> > > +      KSZ8041RLNI: register 0x1e, bits 15..14  
> >                   ^^^^
> > This isn't a bug, but there's a typo here. Should this be KSZ8041RNLI
> > instead of KSZ8041RLNI?  
> 
> Yes, it is a typo. Shall I send a v2 with this fixed?

Yes, please