From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678BF171E6E for ; Mon, 14 Oct 2024 23:57:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728950256; cv=none; b=q6cnNPRrM1+9rEB3hrJw+Kikr7F2bHM3Q8q8nV7dRgLQT7s+MsFdZzBi9z3S/0Gqx8xjfxo3hE31vZJKTEC6FzmE5tuv0qq1YXGxSucuje2WFpmGXNiZHf8S4OlYHlzvrZt7o5SL2Z7cuqlGxEo9xQUI9PQrM9MDZILjt7peSIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728950256; c=relaxed/simple; bh=kX4pqCrBK2GblSEDcTU5YKeWhCLo2dn6mQFQ8uOZoV4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qvDhOZDkssv1U7pTLTfldcwQV9gHD0o/QjQtCtGCY9cm+yxvoSV3NjDkswvQFzeRWcZyF4E9EELtSE3NGO7TKfRAhMGoTS9KBkxjQm/10co9FoGlKCzyLESAU/6R2X14r0TWzTA9RtZc4z1eo+odr7WxHzuznWCuHkcYk8j/nmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GL0I0fTR; arc=none smtp.client-ip=209.85.166.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GL0I0fTR" Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-3a3b8964134so8859105ab.1 for ; Mon, 14 Oct 2024 16:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728950253; x=1729555053; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1PKCpI9LOOmwcDFFAV3Q3WPcNRWD/uWDLb+81DiVqOg=; b=GL0I0fTRc1O+Ueul+L+qosfHmt4i9W/7csSBM49WhloeM9rIU3dDMeiN0AGcU5TtQg xVBJNSuUdx1sRATj5zvZ0jFSs29xl/kUD+e0y2EpTl9dN6KQ1WoLJawV0YNUX3jumi4m /iiM/FKzuUVlXvNts17g8GvdsLOuJvvBJhYw4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728950253; x=1729555053; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1PKCpI9LOOmwcDFFAV3Q3WPcNRWD/uWDLb+81DiVqOg=; b=hgZcvtaMgp6dybXo8kxxkSipBtzBa1AARk9v3Cv9xpAWemyWL/to62fPmYoLCvGhCY tiBX81noZbwVhpmQI39J29I21jSwTc38wO/x4TobpmwIq4T6YeX/0RWSNFcZ3FW1E5Bt 7cPRnneQJ5pT99R/MCkuYeGWpQrjqLnZxwfHWZq9oPevRnBWSyMf5z3o25l4npaOcgzH 0zIPhfgMyEbr8/UJRnvXV8I1UcE32dBddyhvbdHCt4njqoonabLqj9E/jj41zxUgtYyg moo5rcxztCT9hhAtqwRwRfaw7xlTnRfOBlRqXJ5xNq+fyyLCDAHSMAaSCVzDIPEjWw58 u81A== X-Forwarded-Encrypted: i=1; AJvYcCVKqt57EpfRz2dugYwQaVXfcfrq2nluDcvqHPCYTGommode6hVA8tK4VVu2mnMZHgSpLCiE2qM=@vger.kernel.org X-Gm-Message-State: AOJu0YyNe0vmm2jGhU1JzOFdyq+xf/N+HrPPo+pF6+V/oonkwjqMNuvv 1CfT+GdQBQ7DlGhMo+AfVvbJNe3j04H5awBDJePXe641BP1FGlluidKF/FSV7wg= X-Google-Smtp-Source: AGHT+IH0xfL3ktXtZPj3uGodNBsuzJgI8pNk8IlXd2ozjWhgU67nKyr9i4FfLS9KOvhHLZD6fluEQA== X-Received: by 2002:a05:6e02:18cd:b0:3a0:a71b:75e5 with SMTP id e9e14a558f8ab-3a3bcdb421amr71034295ab.7.1728950253468; Mon, 14 Oct 2024 16:57:33 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dbecc6a89asm45032173.173.2024.10.14.16.57.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 16:57:33 -0700 (PDT) Message-ID: Date: Mon, 14 Oct 2024 17:57:31 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 net-next] selftests: tc-testing: Fixed Typo error To: Karan Sanghavi , Jamal Hadi Salim , Cong Wang , Jiri Pirko , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Karan Sanghavi , Shuah Khan References: Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/14/24 10:50, Karan Sanghavi wrote: > This commit combines two fixes for typographical errors > in the "name" fields of the JSON objects with IDs > "4319" and "4341" in the tc-testing selftests. > For the files tc-tests/filters/cgroup.json and > /tc-tests/filters/flow.json. > This is not the correct way to write change logs. There is no need to mention how two commits are combines. State the problem and sya what this patch does e.g: "Fix spelling errors in cgroup.json and flow.json" > v2: > - Combine two earlier patches into one > - Links to v1 of each patch > [1] https://lore.kernel.org/all/Zqp9asVA-q_OzDP-@Emma/ > [2] https://lore.kernel.org/all/Zqp92oXa9joXk4T9@Emma/ > > > Signed-off-by: Karan Sanghavi > --- > tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 2 +- > tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json > index 03723cf84..6897ff5ad 100644 > --- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json > +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json > @@ -1189,7 +1189,7 @@ > }, > { > "id": "4319", > - "name": "Replace cgroup filter with diffferent match", > + "name": "Replace cgroup filter with different match", > "category": [ > "filter", > "cgroup" > diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json > index 58189327f..996448afe 100644 > --- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json > +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json > @@ -507,7 +507,7 @@ > }, > { > "id": "4341", > - "name": "Add flow filter with muliple ops", > + "name": "Add flow filter with multiple ops", > "category": [ > "filter", > "flow" thanks, -- Shuah