From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Keller, Jacob E" <jacob.e.keller@intel.com>
Subject: Re: [PATCH iwl-next v2] ixgbe: Convert ret val type from s32 to int
Date: Wed, 10 Jan 2024 10:56:20 -0800 [thread overview]
Message-ID: <d01570cd-20ba-e804-1e06-03ea30dfa2f7@intel.com> (raw)
In-Reply-To: <DS0PR11MB7785D03E09AC1DFA9F0D71C7F0692@DS0PR11MB7785.namprd11.prod.outlook.com>
On 1/10/2024 3:51 AM, Jagielski, Jedrzej wrote:
> From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Sent: Friday, January 5, 2024 10:50 PM
>
>> On 1/5/2024 2:31 AM, Jedrzej Jagielski wrote:
...
>>> @@ -93,11 +93,11 @@ static s32 ixgbe_get_invariants_82598(struct ixgbe_hw *hw)
>>> * not known. Perform the SFP init if necessary.
>>> *
>>> **/
>>> -static s32 ixgbe_init_phy_ops_82598(struct ixgbe_hw *hw)
>>> +static int ixgbe_init_phy_ops_82598(struct ixgbe_hw *hw)
>>> {
>>> struct ixgbe_mac_info *mac = &hw->mac;
>>> struct ixgbe_phy_info *phy = &hw->phy;
>>> - s32 ret_val;
>>> + int ret_val;
>>> u16 list_offset, data_offset;
>>
>> Should we RCT what we're touching? (many other instances in the patch as
>> well)
>
> I am not sure if that's still in the scope of that patch
Not 100% the same situation, but it could be in the patch [1] or a
separate one [2]. I prefer the latter as that's what I did :)
Thanks,
Tony
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5180ff1364bc26c031b54a68a80aa90ce0028b70
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5518ac2a64423f226e922b6719cf0eb62c31e141
prev parent reply other threads:[~2024-01-10 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 10:31 [PATCH iwl-next v2] ixgbe: Convert ret val type from s32 to int Jedrzej Jagielski
2024-01-05 21:49 ` Tony Nguyen
2024-01-10 11:51 ` Jagielski, Jedrzej
2024-01-10 18:56 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d01570cd-20ba-e804-1e06-03ea30dfa2f7@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).