From: Markus Elfring <Markus.Elfring@web.de>
To: Kory Maincent <kory.maincent@bootlin.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH net] net: pse-pd: pd692x0: Fix power budget leak in manager setup error path
Date: Wed, 20 Aug 2025 16:08:31 +0200 [thread overview]
Message-ID: <d02c9ad2-ea89-4e82-80ad-6d8359f154a1@web.de> (raw)
In-Reply-To: <20250820132708.837255-1-kory.maincent@bootlin.com>
…
> +++ b/drivers/net/pse-pd/pd692x0.c
…
> @@ -1185,31 +1217,27 @@ static int pd692x0_setup_pi_matrix(struct pse_controller_dev *pcdev)
…
> + pd692x0_of_put_managers(priv, manager, nmanagers);
> + return 0;
How do you think about to apply the following code variant?
ret = 0;
goto put_managers;
>
> - for (j = 0; j < manager[i].nports; j++)
> - of_node_put(manager[i].port_node[j]);
> - of_node_put(manager[i].node);
> - }
> +err_managers_req_pw:
free_pw_budget:
> + pd692x0_managers_free_pw_budget(priv);
> +err_of_managers:
put_managers:
> + pd692x0_of_put_managers(priv, manager, nmanagers);
> return ret;
> }
…
Regards,
Markus
next prev parent reply other threads:[~2025-08-20 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 13:27 [PATCH net] net: pse-pd: pd692x0: Fix power budget leak in manager setup error path Kory Maincent
2025-08-20 14:08 ` Markus Elfring [this message]
2025-08-21 15:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d02c9ad2-ea89-4e82-80ad-6d8359f154a1@web.de \
--to=markus.elfring@web.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox