From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEA0C169C4 for ; Wed, 30 Jan 2019 03:39:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 004B921473 for ; Wed, 30 Jan 2019 03:39:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nlhp+lZo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729954AbfA3Djp (ORCPT ); Tue, 29 Jan 2019 22:39:45 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:43981 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbfA3Djo (ORCPT ); Tue, 29 Jan 2019 22:39:44 -0500 Received: by mail-oi1-f195.google.com with SMTP id u18so18074220oie.10 for ; Tue, 29 Jan 2019 19:39:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zGb8I+9wdAlA+0HFV3qAtzkjIlfUFTxjCAistekWbUg=; b=nlhp+lZoUVQ2ERmVxsaA2nbCHocp9tQJq/dhQg/EvsCiceYsnmErlAFGCia7MnZ1QE 6Uyka5uEBHzAXBDJI7Dkd/l52dhb452FRbdByX7iy+Gqd+BWU4gDL96uaoGuwz1wrWQh e4dGNDudX/wjpis4bO6eizCzPdLHQs1NGRhP8ajj/H1E13YsOTu3N8vV4yvZkNOQ1WWY VV3+nJnCSdXuJXpBB9LfkT7t86yg5Tm4fG9b1jv9Y+POwy9YoRxS6AZ5pqQJxbZ2f739 Ka+SBivmNNiW2osdlbUZu4RiLVZZ9IhFEHwJcrRStDe+Q/9kWqi2+6QOCHpouFV0Wcbb g6ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zGb8I+9wdAlA+0HFV3qAtzkjIlfUFTxjCAistekWbUg=; b=p9t2cPnshWRp7n4e6M9iH1tv8t/lQtnF4FKihjiRxAQ/fSlVYmWL0dTvIrGJKq02jf wAkxYZZeUyNBhdDHhhzOx9ECMmA+j7/rf0K2xuZY5ZjpYT2esXHuRmXPZ9nrFgoez5v6 4H9rT5hQXcUShzpMRixCeK/q+Ko+/x0R/xHyspbU68/nnaUj/a0yJS0uyBgCG7tGXGv/ dfTOx0Mvmwc60NLzywmWSkcsALBc99r5M+/RJwcsEUKtY9QnPPmuZ6+XevV49lHvowWV Fiobcper3a/k/pCUzk+agu5GCkvrKOmg2id8mJ0ttmAiG52Yr4VuEB6P4+53llNb2CEB xY7w== X-Gm-Message-State: AJcUukeUXhCiuIPyeDSIEXWM6tPzgGh5pZ5f6vF1GMNWw8T9bh/g5mWt Co0h4yw7xE4sGbDuUd4a5m0= X-Google-Smtp-Source: ALg8bN4GIRiKnEq53nzXTH6B8D7KBshSzDzi9A9CT9Q6Bz7xblcsIRxxomEm4V8qV7RNEdwmeBuuYQ== X-Received: by 2002:aca:ab16:: with SMTP id u22mr11585472oie.249.1548819583135; Tue, 29 Jan 2019 19:39:43 -0800 (PST) Received: from [10.0.2.15] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.gmail.com with ESMTPSA id s66sm166178oia.55.2019.01.29.19.39.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 19:39:42 -0800 (PST) Subject: Re: [PATCHv4 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC To: gerg@kernel.org, sean.wang@mediatek.com, linux-mediatek@lists.infradead.org, bjorn@mork.no, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org Cc: rene@vdorst.com, john@phrozen.org, neil@brown.name References: <20190130012406.28271-1-gerg@kernel.org> <20190130012406.28271-3-gerg@kernel.org> From: Florian Fainelli Message-ID: Date: Tue, 29 Jan 2019 19:39:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190130012406.28271-3-gerg@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/29/19 5:24 PM, gerg@kernel.org wrote: > From: Greg Ungerer > > The MediaTek MT7621 SoC device contains a 7530 switch, and the existing > linux kernel 7530 DSA switch driver can be used with it. > > The bulk of the changes required stem from the 7621 having different > regulator and pad setup. The existing setup of these in the 7530 > driver appears to be very specific to its implemtation in the Mediatek > 7623 SoC. (Not entirely surprising given the 7623 is a quad core ARM > based SoC, and the 7621 is a dual core, dual thread MIPS based SoC). > > Create a new devicetree type, "mediatek,mt7621", to support the 7530 > switch in the 7621 SoC. There appears to be no usable ID register to > distinguish it from a 7530 in other hardware at runtime. This is used > to carry out the appropriate configuration and setup. > > Signed-off-by: Greg Ungerer > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian