From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH bpf-next v3 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps Date: Sun, 3 Jun 2018 18:11:45 +0200 Message-ID: References: <20180602210641.6163-1-daniel@iogearbox.net> <20180602210641.6163-6-daniel@iogearbox.net> <20180603085651.73c76704@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: alexei.starovoitov@gmail.com, netdev@vger.kernel.org To: Jesper Dangaard Brouer Return-path: Received: from www62.your-server.de ([213.133.104.62]:34403 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbeFCQLr (ORCPT ); Sun, 3 Jun 2018 12:11:47 -0400 In-Reply-To: <20180603085651.73c76704@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/03/2018 08:56 AM, Jesper Dangaard Brouer wrote: > On Sat, 2 Jun 2018 23:06:35 +0200 > Daniel Borkmann wrote: > >> Before: >> >> # bpftool p d x i 1 > > Could this please be changed to: > > # bpftool prog dump xlated id 1 > > I requested this before, but you seem to have missed my feedback... > This makes the command "self-documenting" and searchable by Google. I recently wrote a howto here, but there's also excellent documentation in terms of man pages for bpftool. http://cilium.readthedocs.io/en/latest/bpf/#bpftool My original thinking was that it might be okay to also show usage of short option matching, like in iproute2 probably few people only write 'ip address' but majority uses 'ip a' instead. But I'm fine either way if there are strong opinions ... thanks Alexei for fixing up!