From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: John Fastabend <john.fastabend@gmail.com>,
Networking <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [BUG] net/sched : qlen can not really be per cpu ?
Date: Tue, 26 Feb 2019 16:56:49 -0800 [thread overview]
Message-ID: <d075c0f5-c2b5-6ea8-f09a-7af5ba4ce05b@gmail.com> (raw)
In-Reply-To: <CAM_iQpVuaP9kVyvM-s2MFw+cz1tZpp0ehipo7Gm-W8+=UzxuvQ@mail.gmail.com>
On 02/26/2019 03:51 PM, Cong Wang wrote:
> On Tue, Feb 26, 2019 at 3:19 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>
>>
>>
>> On 02/25/2019 10:42 PM, Eric Dumazet wrote:
>>> HTB + pfifo_fast as a leaf qdisc hits badly the following warning in htb_activate() :
>>>
>>> WARN_ON(cl->level || !cl->leaf.q || !cl->leaf.q->q.qlen);
>>>
>>> This is because pfifo_fast does not update sch->q.qlen, but per cpu counters.
>>> So cl->leaf.q->q.qlen is zero.
>>>
>>> HFSC, CBQ, DRR, QFQ have the same problem.
>>>
>>> Any ideas how we can fix this ?
>>
>> What about something simple for stable ?
>> ( I yet have to boot/test this )
>
> Is merely updating qlen sufficient for fixing it?
>
> I thought it is because of the lack of qdisc_tree_reduce_backlog()
> in pfifo_fast.
It does not seem to be the qdisc_tree_reduce_backlog() thing.
HTB, HFSC, CBQ, DRR, QFQ only peek at their children 'qlen' to decide if there
is at least one packet in them.
The backlog is only reported for dumps, but the actual backlog value is not used in data path.
next prev parent reply other threads:[~2019-02-27 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 6:42 [BUG] net/sched : qlen can not really be per cpu ? Eric Dumazet
2019-02-26 23:19 ` Eric Dumazet
2019-02-26 23:51 ` Cong Wang
2019-02-27 0:56 ` Eric Dumazet [this message]
2019-02-27 16:59 ` Eric Dumazet
2019-02-28 2:46 ` Cong Wang
2019-02-28 5:15 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d075c0f5-c2b5-6ea8-f09a-7af5ba4ce05b@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).