From: Paolo Abeni <pabeni@redhat.com>
To: Wesley Atwell <atwellwea@gmail.com>,
netdev@vger.kernel.org, ncardwell@google.com
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
horms@kernel.org, kuba@kernel.org, kuniyu@google.com,
shuah@kernel.org
Subject: Re: [PATCH net-next 1/3] selftests: packetdrill: stop pinning rwnd in tcp_ooo_rcv_mss
Date: Thu, 19 Mar 2026 11:22:45 +0100 [thread overview]
Message-ID: <d0ab8cc8-f734-47d4-b402-9c62ae563b4a@redhat.com> (raw)
In-Reply-To: <20260317065137.1533226-2-atwellwea@gmail.com>
On 3/17/26 7:51 AM, Wesley Atwell wrote:
> tcp_ooo_rcv_mss.pkt cares about the OOO SACK state and the resulting
> tcpi_rcv_mss update.
>
> Its exact advertised receive-window value is incidental to that test and
> can legitimately move when unrelated rwnd accounting changes adjust the
> ACK window.
>
> Drop the hard-coded win 81 checks and keep only the ACK/SACK shape and
> the tcpi_rcv_mss assertion.
I think it would be better to keep the test updated with the kernel
behavior. Having the pktdrill tests bundled together with the kernel
allows for tightly coupling.
@Neal: WDYT?
/P
next prev parent reply other threads:[~2026-03-19 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 6:51 [PATCH net-next 0/3] tcp: fix scaled no-shrink rwnd quantization slack Wesley Atwell
2026-03-17 6:51 ` [PATCH net-next 1/3] selftests: packetdrill: stop pinning rwnd in tcp_ooo_rcv_mss Wesley Atwell
2026-03-19 10:22 ` Paolo Abeni [this message]
2026-03-19 14:51 ` Neal Cardwell
2026-03-19 20:53 ` Wesley Atwell
2026-03-17 6:51 ` [PATCH net-next 2/3] tcp: keep scaled no-shrink window representable Wesley Atwell
2026-03-19 10:50 ` Paolo Abeni
2026-03-19 21:21 ` Wesley Atwell
2026-03-17 6:51 ` [PATCH net-next 3/3] selftests: packetdrill: cover scaled rwnd quantization slack Wesley Atwell
2026-03-22 16:32 ` Simon Baatz
2026-03-24 5:27 ` Wesley Atwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0ab8cc8-f734-47d4-b402-9c62ae563b4a@redhat.com \
--to=pabeni@redhat.com \
--cc=atwellwea@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox