From: Timur Tabi <timur@codeaurora.org>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Mans Rullgard <mans@mansr.com>,
Martin Blumenstingl <martin.blumenstingl@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Zefir Kurtisi <zefir.kurtisi@neratec.com>,
Daniel Mack <zonque@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"David S. Miller" <davem@davemloft.net>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
Mason <slash.tmp@free.fr>
Subject: Re: [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup
Date: Wed, 19 Jul 2017 12:49:50 -0500 [thread overview]
Message-ID: <d0b7027d-1306-a114-00c0-8e3cb01d4d0e@codeaurora.org> (raw)
In-Reply-To: <33ed5f4f-9939-dc00-b973-db39c16f2393@sigmadesigns.com>
On 07/19/2017 10:31 AM, Marc Gonzalez wrote:
> The current code supports enabling RGMII RX and TX clock delays.
> The unstated assumption is that these settings are disabled by
> default at reset, which is not the case.
>
> RX clock delay is enabled at reset. And TX clock delay "survives"
> across SW resets. Thus, if the bootloader enables TX clock delay,
> it will remain enabled at reset in Linux.
>
> Provide disable functions to configure the RGMII clock delays
> exactly as specified in the fwspec.
I only use SGMII mode, and I tested and can confirm that this patch does
not break SGMII, so:
Acked-by: Timur Tabi <timur@codeaurora.org>
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-07-19 17:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 15:29 [PATCH 0/2] Atheros 803x PHY RGMII clock delays Marc Gonzalez
2017-07-19 15:31 ` [PATCH 1/2] net: phy: at803x: Fix RGMII RX and TX clock delays setup Marc Gonzalez
2017-07-19 17:49 ` Timur Tabi [this message]
2017-07-19 19:24 ` Grygorii Strashko
2017-07-19 19:30 ` Florian Fainelli
2017-07-19 20:11 ` Grygorii Strashko
2017-07-19 21:29 ` Mason
2017-07-19 21:44 ` Florian Fainelli
2017-07-19 15:33 ` [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup Marc Gonzalez
2017-07-19 17:17 ` Måns Rullgård
2017-07-19 17:36 ` Mason
2017-07-19 18:30 ` Florian Fainelli
2017-07-19 21:15 ` Mason
2017-07-19 21:34 ` Florian Fainelli
2017-07-20 12:33 ` Mason
2017-07-20 12:39 ` Måns Rullgård
2017-07-24 21:21 ` Mason
2017-07-24 21:49 ` Florian Fainelli
2017-07-24 22:30 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b7027d-1306-a114-00c0-8e3cb01d4d0e@codeaurora.org \
--to=timur@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mans@mansr.com \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=martin.blumenstingl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=slash.tmp@free.fr \
--cc=thibaud_cornic@sigmadesigns.com \
--cc=zefir.kurtisi@neratec.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).