public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Li,Rongqing(ACG CCN)" <lirongqing@baidu.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>,
	Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Frederic Weisbecker <frederic@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Li,Yongkang(ACG CCN)" <liyongkang01@baidu.com>
Subject: 答复: [????] Re: [PATCH][net-next] net/mlx5: Expedite notifier unregistration during device teardown
Date: Mon, 16 Mar 2026 02:21:44 +0000	[thread overview]
Message-ID: <d10a6aaff92249dd9b8e3ec9623492b7@baidu.com> (raw)
In-Reply-To: <20260314105426.36ae4cba@kernel.org>

> On Thu, 12 Mar 2026 05:48:04 -0400 lirongqing wrote:
> > During device hot-unplug, the mlx5 driver expects quickly unregister
> > notification chains. The standard atomic_notifier_chain_unregister()
> > calls synchronize_rcu(), which introduces significant latency and can
> > become a bottleneck during mass resource cleanup.
> >
> > Introduce atomic_notifier_chain_unregister_expedited() to leverage
> > synchronize_rcu_expedited(), and use it significantly reducing wait
> > times in the following paths:
> >  - Event Queue (EQ) notifier chain
> >  - Firmware event notifier chain
> >  - IRQ notifier chain
> >
> > This acceleration ensures faster teardown during hot-unplug events.
> 
> Some detailed example and how long the whole operation takes would be great
> in the commit msg.
> 
OK, I will add in v2 
> >  /**
> > + *	atomic_notifier_chain_unregister_expedited - Remove notifier from an
> atomic notifier chain
> > + *	@nh: Pointer to head of the atomic notifier chain
> > + *	@n: Entry to remove from notifier chain
> > + *
> > + *	Removes a notifier from an atomic notifier chain and forcefully
> > + *	accelerates the RCU grace period.
> > + *
> > + *	Returns zero on success or %-ENOENT on failure.
> 
> Warning: kernel/notifier.c:211 No description found for return value of
> 'atomic_notifier_chain_unregister_expedited'
> 
> kdoc wants you to use Return: or Returns: the colon is how it knows this is the
> doc for return value not just a random mention of the word Returns
> --
I will fix this in v2

Thank you

[Li,Rongqing] 

> pw-bot: cr

      reply	other threads:[~2026-03-16  2:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12  9:48 [PATCH][net-next] net/mlx5: Expedite notifier unregistration during device teardown lirongqing
2026-03-14 17:54 ` Jakub Kicinski
2026-03-16  2:21   ` Li,Rongqing(ACG CCN) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d10a6aaff92249dd9b8e3ec9623492b7@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=frederic@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=liyongkang01@baidu.com \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox