From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F665C43216 for ; Tue, 3 Aug 2021 19:19:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4829B60F56 for ; Tue, 3 Aug 2021 19:19:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239656AbhHCTTc (ORCPT ); Tue, 3 Aug 2021 15:19:32 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:47260 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239734AbhHCTTN (ORCPT ); Tue, 3 Aug 2021 15:19:13 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 173JIhsk019857; Tue, 3 Aug 2021 14:18:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1628018323; bh=rpugVZ13ErhlSCrvrQb8dO8oAMjQUAR/3p8c0Jg+m7Y=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=JHjImjwA9i8L79IpQjStAy3PQ6mfLVejqHAXgIKhCVXBC+E3rKpUkTHW5IsanEFtp 1xwCuM582PhSh5jPvivGAWcRsARhXaIoeD+39PrQIXF1Oom3UjOPuCHu36BhaDWWyr vIg+gMNHgC0GkpRx4wBnEICfVlrWdU9Z8Ie3B8a4= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 173JIh15109192 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Aug 2021 14:18:43 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 3 Aug 2021 14:18:42 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 3 Aug 2021 14:18:42 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 173JIdWf111244; Tue, 3 Aug 2021 14:18:39 -0500 Subject: Re: [PATCH net-next 0/2] Convert switchdev_bridge_port_{,un}offload to notifiers To: Vladimir Oltean CC: "netdev@vger.kernel.org" , Jakub Kicinski , "David S. Miller" , Florian Fainelli , Andrew Lunn , Vivien Didelot , Jiri Pirko , Ido Schimmel , Roopa Prabhu , Nikolay Aleksandrov , Stephen Hemminger , "bridge@lists.linux-foundation.org" , Arnd Bergmann References: <20210803143624.1135002-1-vladimir.oltean@nxp.com> <00acb107-8ff6-9c98-e6c3-f6718d5ce9f4@ti.com> <20210803181534.qgbcjow4ketd4yio@skbuf> From: Grygorii Strashko Message-ID: Date: Tue, 3 Aug 2021 22:18:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210803181534.qgbcjow4ketd4yio@skbuf> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/08/2021 21:15, Vladimir Oltean wrote: > On Tue, Aug 03, 2021 at 08:11:56PM +0300, Grygorii Strashko wrote: >> I've tested builds, but was not able to test bridge itself on TI am57x platform. >> >> 1) See warning >> [ 3.958496] ------------[ cut here ]------------ >> [ 3.963165] WARNING: CPU: 0 PID: 1 at lib/refcount.c:25 fib_create_info+0xae8/0xbd4 >> [ 3.970855] refcount_t: addition on 0; use-after-free. >> [ 3.976043] Modules linked in: autofs4 >> [ 3.979827] CPU: 0 PID: 1 Comm: systemd Not tainted 5.14.0-rc4-next-20210802-00002-g5003e4ac441d-dirty #5 >> [ 3.989440] Hardware name: Generic DRA72X (Flattened Device Tree) >> [ 3.995574] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) >> [ 4.003356] [] (show_stack) from [] (dump_stack_lvl+0x40/0x4c) >> [ 4.010986] [] (dump_stack_lvl) from [] (__warn+0xd8/0x100) >> [ 4.018341] [] (__warn) from [] (warn_slowpath_fmt+0x94/0xbc) >> [ 4.025848] [] (warn_slowpath_fmt) from [] (fib_create_info+0xae8/0xbd4) >> [ 4.034332] [] (fib_create_info) from [] (fib_table_insert+0x5c/0x604¢·†AËÕìÍ_¡ >> >> 2) see warnings and "ip link add name br0 type bridge" just stuck >> [ 158.032135] unregister_netdevice: waiting for lo to become free. Usage count = 3 >> >> It might not be related to this series. > > 100% not me. > > See if you have David Ahern's bug fix, and if you do, try to see what > other refcount conversion patches Yajun Deng did, revert them one by one > and see if any one fixes the issue: > https://patchwork.kernel.org/project/netdevbpf/patch/20210802160221.27263-1-dsahern@kernel.org/ > Yep. That's it. build ok, CONFIG_TI_CPSW_SWITCHDEV=y CONFIG_BRIDGE=m basic bridge with ping - ok. Tested-by: Grygorii Strashko -- Best regards, grygorii