From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE252C43381 for ; Wed, 20 Feb 2019 15:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9168021902 for ; Wed, 20 Feb 2019 15:02:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ysoft.com header.i=@ysoft.com header.b="Shjx8EEk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726361AbfBTPCg (ORCPT ); Wed, 20 Feb 2019 10:02:36 -0500 Received: from uho.ysoft.cz ([81.19.3.130]:41463 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726151AbfBTPCe (ORCPT ); Wed, 20 Feb 2019 10:02:34 -0500 Received: from [10.1.8.111] (unknown [10.1.8.111]) by uho.ysoft.cz (Postfix) with ESMTP id 324E7A4228; Wed, 20 Feb 2019 16:02:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1550674952; bh=tBi2ADOxEKvKai2pC5mdhv7AbtLlDTNVPBUFseZNHhk=; h=To:Cc:From:Subject:Date:From; b=Shjx8EEkz8tcqxuIFypXwEaMeR2rAkuvjRQVYDLYn30osjkXjbkOF/lueQF1MqYuS ihVGO/nejys93YbSPj7eqsCizDrz51N0JTMF2FXvoZU63wIZsaDvwydT+4bLJPacS7 D+jS2jXu4hzjf+NLcj8jROLGmix2V8urjndcgD7Y= To: Andrew Lunn , Vinod Koul , Heiner Kallweit Cc: "David S. Miller" , Florian Fainelli , netdev@vger.kernel.org From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Subject: [RFC] net: dsa: qca8k: CPU port broken with commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") Message-ID: Date: Wed, 20 Feb 2019 16:02:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Another issue in a row with networking on imx6dl-yapp4 platform [1] that uses QCA8334 Ethernet switch. Very recently, with Vinod and Andrew, we solved an issue with RGMII_ID mode by patch[2][3]. I tested those with next-20190215 and it worked just fine. The patch[2] was merged into next-20190220 so I tested the latest version. Now the cpu port does not work again. I tracked it down to this commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") [4] If I revert the offending commit, cpu port works fine. I suspect the problem is on the qca8k driver side but I am not really sure. AFAICT autonegotiation is not available on the QCA833x cpu port (MAC0). Any ideas what may be the root cause of the problem? Thank you, Michal [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=87489ec3a77f3e01bcf0d46e353ae7112ec8c4f0 [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a968b5e9d5879f9535d6099505f9e14abcafb623 [3] https://lore.kernel.org/patchwork/patch/1043817/ [4] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=5502b218e001