Re: [PATCH iproute2-next] ip: support setting multiple features

[David Ahern <dsahern@gmail.com>]

On 5/27/25 3:55 PM, Stanislav Fomichev wrote:
> Commit a043bea75002 ("ip route: add support for TCP usec TS") added
> support for tcp_usec_ts but the existing code was not adjusted
> to handle multiple features in the same invocation:
> 
> $ ip route add .. dev .. features tcp_usec_ts ecn
> Error: either "to" is duplicate, or "ecn" is garbage.
> 
> The code exits the while loop as soon as it encounters any feature,
> make it more flexible. Tested with the following:
> 
> $ ip route add .. dev .. features tcp_usec_ts ecn
> $ ip route add .. dev .. features tcp_usec_ts ecn quickack 1
> 
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Fixes: a043bea75002 ("ip route: add support for TCP usec TS")
> Signed-off-by: Stanislav Fomichev <stfomichev@gmail.com>
> ---
> v2: separate logic into separate function (Stephen)
> ---
>  ip/iproute.c | 38 ++++++++++++++++++++++++++++----------
>  1 file changed, 28 insertions(+), 10 deletions(-)
> 

applied to iproute2-next. Thanks