From: <Arun.Ramadoss@microchip.com>
To: <andrew@lunn.ch>, <olteanv@gmail.com>, <davem@davemloft.net>,
<Woojung.Huh@microchip.com>, <pabeni@redhat.com>,
<o.rempel@pengutronix.de>, <edumazet@google.com>,
<f.fainelli@gmail.com>, <kuba@kernel.org>
Cc: <l.stach@pengutronix.de>, <kernel@pengutronix.de>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v2 3/3] net: dsa: microchip: lan937x: disable VPHY support
Date: Wed, 3 Jul 2024 03:15:06 +0000 [thread overview]
Message-ID: <d147c4363c778c6c94f849c0be0996fa8695fdd0.camel@microchip.com> (raw)
In-Reply-To: <20240701085343.3042567-3-o.rempel@pengutronix.de>
Hi Oleksij,
> ---
> drivers/net/dsa/microchip/lan937x_main.c | 3 +++
> drivers/net/dsa/microchip/lan937x_reg.h | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/net/dsa/microchip/lan937x_main.c
> b/drivers/net/dsa/microchip/lan937x_main.c
> index eaa862eb6b265..0606796b14856 100644
> --- a/drivers/net/dsa/microchip/lan937x_main.c
> +++ b/drivers/net/dsa/microchip/lan937x_main.c
> @@ -390,6 +390,9 @@ int lan937x_setup(struct dsa_switch *ds)
> lan937x_cfg(dev, REG_SW_GLOBAL_OUTPUT_CTRL__1,
> (SW_CLK125_ENB | SW_CLK25_ENB), true);
>
> + /* Disable global VPHY support. Related to CPU interface
> only? */
> + ksz_rmw32(dev, REG_SW_CFG_STRAP_OVR, SW_VPHY_DISABLE,
> SW_VPHY_DISABLE);
Do we need to check the return value of ksz_rmw32?
> +
> return 0;
> }
>
>
next prev parent reply other threads:[~2024-07-03 3:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 8:53 [PATCH net-next v2 1/3] net: dsa: microchip: lan9371/2: add 100BaseTX PHY support Oleksij Rempel
2024-07-01 8:53 ` [PATCH net-next v2 2/3] net: dsa: microchip: lan937x: disable in-band status support for RGMII interfaces Oleksij Rempel
2024-07-01 16:20 ` Vladimir Oltean
2024-07-03 3:09 ` Arun.Ramadoss
2024-07-01 8:53 ` [PATCH net-next v2 3/3] net: dsa: microchip: lan937x: disable VPHY support Oleksij Rempel
2024-07-01 16:21 ` Vladimir Oltean
2024-07-03 3:15 ` Arun.Ramadoss [this message]
2024-07-01 14:55 ` [PATCH net-next v2 1/3] net: dsa: microchip: lan9371/2: add 100BaseTX PHY support Arun.Ramadoss
2024-07-03 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d147c4363c778c6c94f849c0be0996fa8695fdd0.camel@microchip.com \
--to=arun.ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox