From mboxrd@z Thu Jan 1 00:00:00 1970 From: "santosh.shilimkar@oracle.com" Subject: Re: [PATCH 1/1] net/rds: Use rdma_read_gids to get connection SGID/DGID in IPv6 Date: Sat, 25 Aug 2018 12:24:17 -0700 Message-ID: References: <20180825071905.2749-1-yanjun.zhu@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Zhu Yanjun , davem@davemloft.net, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:40900 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbeHYXEU (ORCPT ); Sat, 25 Aug 2018 19:04:20 -0400 In-Reply-To: <20180825071905.2749-1-yanjun.zhu@oracle.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 8/25/18 12:19 AM, Zhu Yanjun wrote: > In IPv4, the newly introduced rdma_read_gids is used to read the SGID/DGID > for the connection which returns GID correctly for RoCE transport as well. > > In IPv6, rdma_read_gids is also used. The following are why rdma_read_gids > is introduced. > > rdma_addr_get_dgid() for RoCE for client side connections returns MAC > address, instead of DGID. > rdma_addr_get_sgid() for RoCE doesn't return correct SGID for IPv6 and > when more than one IP address is assigned to the netdevice. > > So the transport agnostic rdma_read_gids() API is provided by rdma_cm > module. > > Signed-off-by: Zhu Yanjun > --- Looks ok. Acked-by: Santosh Shilimkar