public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
To: "Eric Dumazet" <eric.dumazet@gmail.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	Rama Nichanamatlu <rama.nichanamatlu@oracle.com>,
	Sergey Linetskiy <sergey.linetskiy@oracle.com>,
	Vadim Makhervaks <vadim.makhervaks@oracle.com>,
	Guangyu Sun <guangyu.sun@oracle.com>
Subject: RE: Performance problem with bond interface
Date: Tue, 22 Apr 2014 10:04:25 -0700 (PDT)	[thread overview]
Message-ID: <d1712c10-930c-46e8-b1bb-7ce764b67479@default> (raw)
In-Reply-To: <a4c977be-1a10-4c47-9b39-c3905161746d@default>

What is the purpose of initializing "features"
with NETIF_F_HW_CSUM in bond_setup() ?

[drivers/net/bonding/bond_main.c] bond-setup():
bond_dev->hw_features &= ~(NETIF_F_ALL_CSUM & ~NETIF_F_HW_CSUM);
bond_dev->features |= bond_dev->hw_features;

If netdev_increment_features() adds features in
incremental fashion then shouldn't bond let the
features such as NETIF_F_HW_CSUM be added when
netdev_increment_features() is called for each slave
in bond_compute_features() if the slave supports it ?

Thanks.

Venkat

      reply	other threads:[~2014-04-22 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 14:23 Performance problem with bond interface Venkat Venkatsubra
2014-04-21 15:47 ` Eric Dumazet
2014-04-21 18:32   ` Venkat Venkatsubra
2014-04-22 17:04     ` Venkat Venkatsubra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1712c10-930c-46e8-b1bb-7ce764b67479@default \
    --to=venkat.x.venkatsubra@oracle.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=guangyu.sun@oracle.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=netdev@vger.kernel.org \
    --cc=rama.nichanamatlu@oracle.com \
    --cc=sergey.linetskiy@oracle.com \
    --cc=vadim.makhervaks@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox