From: David Ahern <dsahern@kernel.org>
To: Guillaume Nault <gnault@redhat.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next 1/3] ping: Stop using RTO_ONLINK.
Date: Tue, 23 May 2023 09:09:11 -0600 [thread overview]
Message-ID: <d18721ef-5938-0fab-73a1-238fb5fb2aaa@kernel.org> (raw)
In-Reply-To: <f4ceb3ad415f7353885baf0a0dc56226ebe8302e.1684764727.git.gnault@redhat.com>
On 5/22/23 8:37 AM, Guillaume Nault wrote:
> Define a new helper to figure out the correct route scope to use on TX,
> depending on socket configuration, ancillary data and send flags.
>
> Use this new helper to properly initialise the scope in
> flowi4_init_output(), instead of overriding tos with the RTO_ONLINK
> flag.
>
> The objective is to eventually remove RTO_ONLINK, which will allow
> converting .flowi4_tos to dscp_t.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
> ---
> include/net/ip.h | 13 +++++++++++++
> net/ipv4/ping.c | 15 +++++----------
> 2 files changed, 18 insertions(+), 10 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-05-23 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 14:37 [PATCH net-next 0/3] ipv4: Remove RTO_ONLINK from udp, ping and raw sockets Guillaume Nault
2023-05-22 14:37 ` [PATCH net-next 1/3] ping: Stop using RTO_ONLINK Guillaume Nault
2023-05-23 15:09 ` David Ahern [this message]
2023-05-22 14:38 ` [PATCH net-next 2/3] raw: " Guillaume Nault
2023-05-23 15:13 ` David Ahern
2023-05-22 14:38 ` [PATCH net-next 3/3] udp: " Guillaume Nault
2023-05-23 15:14 ` David Ahern
2023-05-24 7:30 ` [PATCH net-next 0/3] ipv4: Remove RTO_ONLINK from udp, ping and raw sockets patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d18721ef-5938-0fab-73a1-238fb5fb2aaa@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).