netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Bobby Eshleman <bobbyeshleman@gmail.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Shuah Khan <shuah@kernel.org>
Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Simon Horman <horms@kernel.org>,
	Bobby Eshleman <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next v4 00/12] selftests/vsock: refactor and improve vmtest infrastructure
Date: Tue, 11 Nov 2025 13:33:11 +0100	[thread overview]
Message-ID: <d19c7bea-9b4d-4f00-a6bc-35247011e788@redhat.com> (raw)
In-Reply-To: <20251108-vsock-selftests-fixes-and-improvements-v4-0-d5e8d6c87289@meta.com>

On 11/8/25 5:00 PM, Bobby Eshleman wrote:
> This patch series refactors the vsock selftest VM infrastructure to
> improve test run times, improve logging, and prepare for future tests
> which make heavy usage of these refactored functions and have new
> requirements such as simultaneous QEMU processes.
> 
> These patches were broken off from this prior series:
> https://lore.kernel.org/all/20251021-vsock-vmtest-v7-0-0661b7b6f081@meta.com/
> 
> To: Stefano Garzarella <sgarzare@redhat.com>
> To: Shuah Khan <shuah@kernel.org>
> Cc: virtualization@lists.linux.dev
> Cc: netdev@vger.kernel.org
> Cc: linux-kselftest@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Simon Horman <horms@kernel.org>
> 
> Changes in v4:
> - fix messed up rebase (wrt check_result() and shared_vm_test() patches)
> - more consistent variable quotes style
> - use associative array for pidfiles, remove after terminate
> - Link to v3: https://lore.kernel.org/r/20251106-vsock-selftests-fixes-and-improvements-v3-0-519372e8a07b@meta.com
> 
> Changes in v3:
> - see per-patch changes
> - Link to v2: https://lore.kernel.org/all/20251104-vsock-selftests-fixes-and-improvements-v2-0-ca2070fd1601@meta.com
> 
> Changes in v2:
> - remove "Fixes" for some patches because they do not fix bugs in
>   kselftest runs (some fix bugs only when using bash args that kselftest
>   does not use or otherwise prepare functions for new usage)
> - broke out one fixes patch for "net"
> - per-patch changes
> - add patch for shellcheck declaration to disable false positives
> - Link to v1: https://lore.kernel.org/r/20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com

Series LGTM, but let's wait a little bit more for explicit ack from Stefano.

Thanks,

Paolo


  parent reply	other threads:[~2025-11-11 12:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-08 16:00 [PATCH net-next v4 00/12] selftests/vsock: refactor and improve vmtest infrastructure Bobby Eshleman
2025-11-08 16:00 ` [PATCH net-next v4 01/12] selftests/vsock: improve logging in vmtest.sh Bobby Eshleman
2025-11-12 11:15   ` Stefano Garzarella
2025-11-08 16:00 ` [PATCH net-next v4 02/12] selftests/vsock: make wait_for_listener() work even if pipefail is on Bobby Eshleman
2025-11-12 11:15   ` Stefano Garzarella
2025-11-08 16:00 ` [PATCH net-next v4 03/12] selftests/vsock: reuse logic for vsock_test through wrapper functions Bobby Eshleman
2025-11-12 11:19   ` Stefano Garzarella
2025-11-08 16:00 ` [PATCH net-next v4 04/12] selftests/vsock: avoid multi-VM pidfile collisions with QEMU Bobby Eshleman
2025-11-12 11:22   ` Stefano Garzarella
2025-11-08 16:00 ` [PATCH net-next v4 05/12] selftests/vsock: do not unconditionally die if qemu fails Bobby Eshleman
2025-11-12 11:23   ` Stefano Garzarella
2025-11-08 16:00 ` [PATCH net-next v4 06/12] selftests/vsock: speed up tests by reducing the QEMU pidfile timeout Bobby Eshleman
2025-11-12 11:24   ` Stefano Garzarella
2025-11-08 16:00 ` [PATCH net-next v4 07/12] selftests/vsock: add check_result() for pass/fail counting Bobby Eshleman
2025-11-12 11:24   ` Stefano Garzarella
2025-11-08 16:00 ` [PATCH net-next v4 08/12] selftests/vsock: identify and execute tests that can re-use VM Bobby Eshleman
2025-11-12 11:27   ` Stefano Garzarella
2025-11-08 16:01 ` [PATCH net-next v4 09/12] selftests/vsock: add BUILD=0 definition Bobby Eshleman
2025-11-12 11:27   ` Stefano Garzarella
2025-11-08 16:01 ` [PATCH net-next v4 10/12] selftests/vsock: add 1.37 to tested virtme-ng versions Bobby Eshleman
2025-11-08 16:01 ` [PATCH net-next v4 11/12] selftests/vsock: add vsock_loopback module loading Bobby Eshleman
2025-11-08 16:01 ` [PATCH net-next v4 12/12] selftests/vsock: disable shellcheck SC2317 and SC2119 Bobby Eshleman
2025-11-12 11:28   ` Stefano Garzarella
2025-11-11 12:33 ` Paolo Abeni [this message]
2025-11-12 11:29   ` [PATCH net-next v4 00/12] selftests/vsock: refactor and improve vmtest infrastructure Stefano Garzarella
2025-11-12 14:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d19c7bea-9b4d-4f00-a6bc-35247011e788@redhat.com \
    --to=pabeni@redhat.com \
    --cc=bobbyeshleman@gmail.com \
    --cc=bobbyeshleman@meta.com \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=shuah@kernel.org \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).