From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E76A3A5E6D for ; Tue, 11 Nov 2025 12:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762864399; cv=none; b=V7z+UXqI05lAxq0dQlphiRHTfaSM2ZsaQ7Du7m/vqsayaU1Xdy8arEIEDZaS/8N5e2t3zhOKj9bvYY2j9Gron86YvRmDZJzvEXozkGjUKMFk6c7/NV2AFuzqifSIjfjV7l22PON/UIKovZ7fj/+1q/NCTg10YEcP4P/Mu4qTmGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762864399; c=relaxed/simple; bh=iOWBNEkhaYulz60fd9nqYbYaUth2lUkhdRV+MRZ+GSk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G1KIRlrPxORwrBmIsqrk/v8whHZyMbV76Qukhcc97Phsh2ltK3zxq9p5Z2CGPGoiS/Nq2jpi6iWte8bq23CiqjdsQ+0FeLbZBlNveHWbup1rUe6VwFhOSQF/AMYI7ea4AYBz/NhIOJUhpvy9p7YLHsB8Ij7B5FGae17udUJiBn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HaT6A4Kb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qMSKEmH5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HaT6A4Kb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qMSKEmH5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762864396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TEMqTiIls3GK+BcBgDdLsrWg6wcMid5JirlC8x4cCJQ=; b=HaT6A4KbAtUPsaV3KjuB6fdoIR80uKtD7yDGnJjr6MhJDzPxajOECkbaprtSAD/H5hn8pv K3BTCvd87F8qBpvTs8rsvyI8m6630wqK98zjKcFXfO3nAhq1D4fd2i/8nuqiyd+0PGU5pv bAIwJf/bqfiuPYCOM5oJWUT14/9sHKc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-uJhHqeYgPBKj2JncLGQiig-1; Tue, 11 Nov 2025 07:33:15 -0500 X-MC-Unique: uJhHqeYgPBKj2JncLGQiig-1 X-Mimecast-MFC-AGG-ID: uJhHqeYgPBKj2JncLGQiig_1762864394 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-42b3d7c1377so1192808f8f.2 for ; Tue, 11 Nov 2025 04:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762864394; x=1763469194; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TEMqTiIls3GK+BcBgDdLsrWg6wcMid5JirlC8x4cCJQ=; b=qMSKEmH5zh3ctqKDwnt6cCK2+TpyDorwqW+f8NzcPEqfJ4MLx0ndMhrwyL7zZLp1zt 16zSbtXJ0s2I2KcT6CiFZNzRLm2KJOFSuj0BHYqi51ODGXmNF3qxzivmpGQrYbKbCuES 3wJy/skHPhdtEAk4Kw7EkNtROAvRgIlLxDZpD5GZURWN6EUGEKEV5npVlLk0/h10kjq4 BeN+znXsUmWfOEDrJK2NmRGjJ9sa+3EqHdM5feeSgyzjeHSlfq+arBRMCZVBZdD0ZhR2 VFnnE+6qwQewC7Ta9i81j70XtYWHLJdQ0V8GKCQNzF4+t+HH+780qPkFILuFjgN/WSc6 QDQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762864394; x=1763469194; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TEMqTiIls3GK+BcBgDdLsrWg6wcMid5JirlC8x4cCJQ=; b=C/YXv2IPPn4sGl8Ss//OflbZPmXXQQgx5WQgzrqCjCD4pTC1mW/HQMY9TkUVIdp4F9 qKJfFaZoPNSe8wCSFDCd412mknFPqNpC/g+KQ3tXVqAVpHpZ97Wx8S2iGs5ecW7/ZDEP inop7mgcYxIOWrf4gSTyAfuoXLEf8nIs+kw/fDxuhUiQxDxrjFZ2f/g5jpvrI+Sg6IFt Q3X03/v+e4pvF/PY1pztyJF5pGpCguuYllouU2AdrTIV3qjdoXB30k4zJ1A98LhXL3T0 AXVu+E5dwN/dshmw1jbH2ZHogvmp0MfY2ZNdZcTpSXfHrx6mk3Ub7sirb7p4bkijViWh rNCA== X-Forwarded-Encrypted: i=1; AJvYcCWKOEDHF9uBhA0XhLgUM67Hoqn9ozf/zvyQ4+A/B1sA1vOxx33B5rl6S8p8ZS4Qwd1NhgisgHk=@vger.kernel.org X-Gm-Message-State: AOJu0YxkGTVhHZT2IxUOgfH9epCBh22xfgBPutFdKUJk23c3/dW11oYu vZ00Wy78l5hOFh7i+JbrmwjJY1aR8pGghRC3WYw1+4JY/bE6IzpSQf9GJD0JkBQT1YY7cp8j+US Jd3xnFHPGHUW6vOPSkyC8wjGQkFFFQIE5boJTwFbeBNu2kea6islk5OUdrA== X-Gm-Gg: ASbGnct+FqoYiJMQv4m80khsvmdq1yLN4xWf04rOuiYrtGInZJM0QrFHGvcG07J/XQO HuwAd/LM5IMdbWu3RML/kYtDSl53Vfo2NuEtDDqpCxuohl9pkSmnHudHL2LpYiSy2qAdSWpJRqp XcFCyGODKvcfFKJiIs1qGYK23R2M4LnxFx7ZNiZHw3x83ko6gAdz5rK2I8TJDO4LUulOupaUxya /6ygfq/ODKrQrc9JzoH1f0K4vfFkB/OpaLevey/soGhGDgijn4NxzDa4cLKuVNtm1YQpTsNNZp5 diVy7ZPcQszsdY9ZDzyaQaUie9aQZ9VMENWfaOWsJ8irLuTsrD9QGk5rdHGoNPEBpkMuNyZd6Pf e+A== X-Received: by 2002:a5d:5f53:0:b0:42b:32c3:3949 with SMTP id ffacd0b85a97d-42b32c341e4mr8571487f8f.31.1762864393733; Tue, 11 Nov 2025 04:33:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEogtUOY4yTdf1DuIqascBGW9c45+fo19oaNrpbIqMX41Hc32xWFtKascZRxunxinjoalWo2A== X-Received: by 2002:a5d:5f53:0:b0:42b:32c3:3949 with SMTP id ffacd0b85a97d-42b32c341e4mr8571452f8f.31.1762864393278; Tue, 11 Nov 2025 04:33:13 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42ac6794f6esm31385653f8f.41.2025.11.11.04.33.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Nov 2025 04:33:12 -0800 (PST) Message-ID: Date: Tue, 11 Nov 2025 13:33:11 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 00/12] selftests/vsock: refactor and improve vmtest infrastructure To: Bobby Eshleman , Stefano Garzarella , Shuah Khan Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman , Bobby Eshleman References: <20251108-vsock-selftests-fixes-and-improvements-v4-0-d5e8d6c87289@meta.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251108-vsock-selftests-fixes-and-improvements-v4-0-d5e8d6c87289@meta.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/8/25 5:00 PM, Bobby Eshleman wrote: > This patch series refactors the vsock selftest VM infrastructure to > improve test run times, improve logging, and prepare for future tests > which make heavy usage of these refactored functions and have new > requirements such as simultaneous QEMU processes. > > These patches were broken off from this prior series: > https://lore.kernel.org/all/20251021-vsock-vmtest-v7-0-0661b7b6f081@meta.com/ > > To: Stefano Garzarella > To: Shuah Khan > Cc: virtualization@lists.linux.dev > Cc: netdev@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Simon Horman > > Changes in v4: > - fix messed up rebase (wrt check_result() and shared_vm_test() patches) > - more consistent variable quotes style > - use associative array for pidfiles, remove after terminate > - Link to v3: https://lore.kernel.org/r/20251106-vsock-selftests-fixes-and-improvements-v3-0-519372e8a07b@meta.com > > Changes in v3: > - see per-patch changes > - Link to v2: https://lore.kernel.org/all/20251104-vsock-selftests-fixes-and-improvements-v2-0-ca2070fd1601@meta.com > > Changes in v2: > - remove "Fixes" for some patches because they do not fix bugs in > kselftest runs (some fix bugs only when using bash args that kselftest > does not use or otherwise prepare functions for new usage) > - broke out one fixes patch for "net" > - per-patch changes > - add patch for shellcheck declaration to disable false positives > - Link to v1: https://lore.kernel.org/r/20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com Series LGTM, but let's wait a little bit more for explicit ack from Stefano. Thanks, Paolo