Re: [PATCH net-next v2 2/5] ice: configure FW logging

[Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>]

On 8/11/2023 3:05 AM, Simon Horman wrote:
> On Thu, Aug 10, 2023 at 10:01:06AM -0700, Tony Nguyen wrote:
>> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>>
>> Users want the ability to debug FW issues by retrieving the
>> FW logs from the E8xx devices. Use debugfs to allow the user to
>> read/write the FW log configuration by adding a 'fwlog/modules' file.
>> Reading the file will show either the currently running configuration or
>> the next configuration (if the user has changed the configuration).
>> Writing to the file will update the configuration, but NOT enable the
>> configuration (that is a separate command).
> 
> ...
> 
>> @@ -5635,10 +5653,14 @@ static int __init ice_module_init(void)
>>   		goto err_dest_wq;
>>   	}
>>   
>> +	ice_debugfs_init();
>> +
>>   	status = pci_register_driver(&ice_driver);
>>   	if (status) {
>>   		pr_err("failed to register PCI driver, err %d\n", status);
>>   		goto err_dest_lag_wq;
>> +		destroy_workqueue(ice_wq);
>> +		ice_debugfs_exit();
> 
> Hi Paul and Tony,
> 
> this new code seems to be unreachable.
> Should it go before the goto statement?
> 

Good catch! This has been fixed in Tony's tree

Paul

>>   	}
>>   
>>   	return 0;
> 
> ...