From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A1CC282C4 for ; Mon, 4 Feb 2019 21:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B82A120811 for ; Mon, 4 Feb 2019 21:09:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pO8bYoKm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729235AbfBDVJR (ORCPT ); Mon, 4 Feb 2019 16:09:17 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53707 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728004AbfBDVJR (ORCPT ); Mon, 4 Feb 2019 16:09:17 -0500 Received: by mail-wm1-f68.google.com with SMTP id d15so1408105wmb.3 for ; Mon, 04 Feb 2019 13:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kAIaZIBKdDfcHuYVGAosAxh+2Irs+287Q0A5HNjwIfA=; b=pO8bYoKm2a+4gkA28Xjuezw7rz0gCv2h+3WulMszVLXCBk8WJ7J6jE7v4RLpzdJu7p KmJP8ixNiDAOEFisdNtNvVC1wW3CnXJrj2EYtBvzk9aoFdKv3B0nz3SnPO+i92AiH+JB 9VUTJMFzx9OcobMFJhvfLoQQV6dGj4plRlq/TAcupyFJenGfjCHIsE4jZHkDIJrZQNta h7qjYojGha4BYCZMu4sY0pjrfEN6YE25pibYOTH9NbPpcPHxl3A2Q/qygwEVzEBHLZfx MHFxbh0+KPZsR9BeqHiAZqk0NTHVIajWFjx9ttvosUzNy7ym/OtVQcyEMrsZGDdXd9tZ 3+AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kAIaZIBKdDfcHuYVGAosAxh+2Irs+287Q0A5HNjwIfA=; b=IkZFDbBJRfVyLXP0tcf4HXT23sWRWj6uAUBuPPibRmyfUMAIuTEhXvIJ/tFb7IVpYV EPblEGeifJxKSXp/M9/nI1UprPiVKAemBqWh32V+qo804FGNWm4+Hj3meDmNWd1aBiT3 3RbN4J7pdev5QejW+2igDFYryXp+CnlCUzs4NvDQw2EyDOPTwKGtCeN3KQ2h+EklzD1A bJhONDO/dPY5Ziue3Qn6P6KMsvi/cqJPbyaFFgfrXkNTEpnpWn0mWdeTPXy3d5b90H4l IUowMDvuUZ7freZfl1B3oq5DCpgRCn/LRdiELtxF1RgX6Vb/6HpD4xT99MyVOBcFtdqE Az6g== X-Gm-Message-State: AHQUAuYqA1OPQINeENI9LlIPrjH+Y6qgUF48gCQQ50emcACEt8dzDEur 15InXRzLF1fnnrU3DA+5vWjrajBW X-Google-Smtp-Source: AHgI3IZ5uaE3lFt/Hn+3KwxXEdrrfaYLUXDGnmtZn4KLZ9h0r7kf9R7bmr4glbb5J7fDKfU3Tgh9IQ== X-Received: by 2002:a1c:4e02:: with SMTP id g2mr971247wmh.4.1549314554681; Mon, 04 Feb 2019 13:09:14 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:79d1:9f16:256f:82a8? (p200300EA8BF1E20079D19F16256F82A8.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:79d1:9f16:256f:82a8]) by smtp.googlemail.com with ESMTPSA id j24sm20130213wrd.86.2019.02.04.13.09.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 13:09:13 -0800 (PST) Subject: [PATCH 1/3 net-next] net: phy: aquantia: improve setting speed and duplex in aqr_read_status From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: Nikita Yushchenko , "netdev@vger.kernel.org" References: <8e41695d-a23e-adad-ae3d-66a46d1ab077@gmail.com> Message-ID: Date: Mon, 4 Feb 2019 22:03:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <8e41695d-a23e-adad-ae3d-66a46d1ab077@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add support for speeds 10Mbps, 5Gbps, and 10Gbps. In addition don't hardcode duplex but read it from the chip. Signed-off-by: Andrew Lunn Signed-off-by: Heiner Kallweit --- drivers/net/phy/aquantia.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c index 482004efa..51ae3feea 100644 --- a/drivers/net/phy/aquantia.c +++ b/drivers/net/phy/aquantia.c @@ -133,6 +133,12 @@ static int aqr_read_status(struct phy_device *phydev) reg = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_AN_TX_VEND_STATUS1); switch (reg & MDIO_AN_TX_VEND_STATUS1_RATE_MASK) { + case MDIO_AN_TX_VEND_STATUS1_10GBASET: + phydev->speed = SPEED_10000; + break; + case MDIO_AN_TX_VEND_STATUS1_5000BASET: + phydev->speed = SPEED_5000; + break; case MDIO_AN_TX_VEND_STATUS1_2500BASET: phydev->speed = SPEED_2500; break; @@ -142,11 +148,15 @@ static int aqr_read_status(struct phy_device *phydev) case MDIO_AN_TX_VEND_STATUS1_100BASETX: phydev->speed = SPEED_100; break; + case MDIO_AN_TX_VEND_STATUS1_10BASET: + phydev->speed = SPEED_10; + break; default: - phydev->speed = SPEED_10000; + phydev->speed = SPEED_UNKNOWN; break; } - phydev->duplex = DUPLEX_FULL; + + phydev->duplex = !!(reg & MDIO_AN_TX_VEND_STATUS1_FULL_DUPLEX); return 0; } -- 2.20.1