From: Paolo Abeni <pabeni@redhat.com>
To: Daniel Jurgens <danielj@nvidia.com>, netdev@vger.kernel.org
Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
virtualization@lists.linux.dev, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, jiri@nvidia.com
Subject: Re: [PATCH net-next v5 2/6] virtio_net: Remove command data from control_buf
Date: Fri, 26 Apr 2024 11:34:05 +0200 [thread overview]
Message-ID: <d1ff9e85ee4bf1b6347e2ebbf28490645e0cd8b7.camel@redhat.com> (raw)
In-Reply-To: <20240423035746.699466-3-danielj@nvidia.com>
On Tue, 2024-04-23 at 06:57 +0300, Daniel Jurgens wrote:
> Allocate memory for the data when it's used. Ideally the could be on the
Minor nit: 'buffer' or 'struct' is missing here ^^^^
No need to repost just for this.
Thank,
Paolo
next prev parent reply other threads:[~2024-04-26 9:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 3:57 [PATCH net-next v5 0/6] Remove RTNL lock protection of CVQ Daniel Jurgens
2024-04-23 3:57 ` [PATCH net-next v5 1/6] virtio_net: Store RSS setting in virtnet_info Daniel Jurgens
2024-04-23 3:57 ` [PATCH net-next v5 2/6] virtio_net: Remove command data from control_buf Daniel Jurgens
2024-04-26 9:34 ` Paolo Abeni [this message]
2024-05-01 2:22 ` Heng Qi
2024-04-23 3:57 ` [PATCH net-next v5 3/6] virtio_net: Add a lock for the command VQ Daniel Jurgens
2024-04-26 9:38 ` Paolo Abeni
2024-04-23 3:57 ` [PATCH net-next v5 4/6] virtio_net: Do DIM update for specified queue only Daniel Jurgens
2024-04-23 3:57 ` [PATCH net-next v5 5/6] virtio_net: Add a lock for per queue RX coalesce Daniel Jurgens
2024-04-26 9:47 ` Paolo Abeni
2024-04-26 13:14 ` Dan Jurgens
2024-04-23 3:57 ` [PATCH net-next v5 6/6] virtio_net: Remove rtnl lock protection of command buffers Daniel Jurgens
2024-04-26 9:53 ` [PATCH net-next v5 0/6] Remove RTNL lock protection of CVQ Paolo Abeni
2024-04-26 13:16 ` Dan Jurgens
2024-04-26 10:08 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ff9e85ee4bf1b6347e2ebbf28490645e0cd8b7.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).