From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, donald.hunter@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, jiri@resnulli.us,
arkadiusz.kubalewski@intel.com, aleksandr.loktionov@intel.com,
michal.michalik@intel.com
Subject: Re: [PATCH net 04/10] netlink: specs: dpll: replace underscores with dashes in names
Date: Tue, 24 Jun 2025 23:58:31 +0100 [thread overview]
Message-ID: <d20c4397-0d77-4053-8ff7-cb9af2d16ade@linux.dev> (raw)
In-Reply-To: <20250624211002.3475021-5-kuba@kernel.org>
On 24/06/2025 22:09, Jakub Kicinski wrote:
> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen, if used, replaces special
> chars in names) but it gives more uniform naming in Python.
>
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jiri@resnulli.us
> CC: arkadiusz.kubalewski@intel.com
> CC: aleksandr.loktionov@intel.com
> CC: michal.michalik@intel.com
> CC: vadim.fedorenko@linux.dev
> ---
> Documentation/netlink/specs/dpll.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
> index 8feefeae5376..f434140b538e 100644
> --- a/Documentation/netlink/specs/dpll.yaml
> +++ b/Documentation/netlink/specs/dpll.yaml
> @@ -188,7 +188,7 @@ doc: DPLL subsystem.
> value: 10000
> -
> type: const
> - name: pin-frequency-77_5-khz
> + name: pin-frequency-77-5-khz
> value: 77500
> -
> type: const
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2025-06-24 22:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 21:09 [PATCH net 00/10] netlink: specs: enforce strict naming of properties Jakub Kicinski
2025-06-24 21:09 ` [PATCH net 01/10] netlink: specs: nfsd: replace underscores with dashes in names Jakub Kicinski
2025-06-25 9:49 ` Donald Hunter
2025-06-25 11:35 ` Jeff Layton
2025-06-26 12:58 ` Chuck Lever
2025-06-24 21:09 ` [PATCH net 02/10] netlink: specs: fou: " Jakub Kicinski
2025-06-25 9:51 ` Donald Hunter
2025-06-24 21:09 ` [PATCH net 03/10] netlink: specs: ethtool: " Jakub Kicinski
2025-06-24 23:07 ` Kory Maincent
2025-06-24 23:14 ` Jakub Kicinski
2025-06-25 9:51 ` Donald Hunter
2025-06-24 21:09 ` [PATCH net 04/10] netlink: specs: dpll: " Jakub Kicinski
2025-06-24 22:58 ` Vadim Fedorenko [this message]
2025-06-25 9:52 ` Donald Hunter
2025-06-24 21:09 ` [PATCH net 05/10] netlink: specs: devlink: " Jakub Kicinski
2025-06-24 22:34 ` Jacob Keller
2025-06-25 9:52 ` Donald Hunter
2025-06-24 21:09 ` [PATCH net 06/10] netlink: specs: ovs_flow: " Jakub Kicinski
2025-06-25 9:52 ` Donald Hunter
2025-06-25 10:15 ` Ilya Maximets
2025-06-25 11:21 ` Eelco Chaudron
2025-06-24 21:09 ` [PATCH net 07/10] netlink: specs: mptcp: " Jakub Kicinski
2025-06-25 9:34 ` Davide Caratti
2025-06-25 9:53 ` Donald Hunter
2025-06-25 12:07 ` Matthieu Baerts
2025-06-24 21:10 ` [PATCH net 08/10] netlink: specs: rt-link: " Jakub Kicinski
2025-06-24 22:33 ` Jacob Keller
2025-06-25 9:54 ` Donald Hunter
2025-06-24 21:10 ` [PATCH net 09/10] netlink: specs: tc: " Jakub Kicinski
2025-06-25 9:54 ` Donald Hunter
2025-06-24 21:10 ` [PATCH net 10/10] netlink: specs: enforce strict naming of properties Jakub Kicinski
2025-06-25 10:05 ` Donald Hunter
2025-06-25 22:50 ` [PATCH net 00/10] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20c4397-0d77-4053-8ff7-cb9af2d16ade@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=michal.michalik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).