From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH bpf-next 10/13] bpf, mips64: remove obsolete exception handling from div/mod Date: Fri, 26 Jan 2018 14:39:52 -0800 Message-ID: References: <20180126223348.11250-1-daniel@iogearbox.net> <20180126223348.11250-11-daniel@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, David Daney To: Daniel Borkmann , ast@kernel.org Return-path: Received: from mail-sn1nam01on0058.outbound.protection.outlook.com ([104.47.32.58]:45770 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752337AbeAZWj4 (ORCPT ); Fri, 26 Jan 2018 17:39:56 -0500 In-Reply-To: <20180126223348.11250-11-daniel@iogearbox.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 01/26/2018 02:33 PM, Daniel Borkmann wrote: > Since we've changed div/mod exception handling for src_reg in > eBPF verifier itself, remove the leftovers from mips64 JIT. > > Signed-off-by: Daniel Borkmann > Cc: David Daney I didn't test it, but this looks correct, so ... Reviewed-by: David Daney > --- > arch/mips/net/ebpf_jit.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/mips/net/ebpf_jit.c b/arch/mips/net/ebpf_jit.c > index 4e34703..296f1410 100644 > --- a/arch/mips/net/ebpf_jit.c > +++ b/arch/mips/net/ebpf_jit.c > @@ -860,11 +860,6 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx, > break; > case BPF_DIV: > case BPF_MOD: > - b_off = b_imm(exit_idx, ctx); > - if (is_bad_offset(b_off)) > - return -E2BIG; > - emit_instr(ctx, beq, src, MIPS_R_ZERO, b_off); > - emit_instr(ctx, movz, MIPS_R_V0, MIPS_R_ZERO, src); > emit_instr(ctx, ddivu, dst, src); > if (bpf_op == BPF_DIV) > emit_instr(ctx, mflo, dst); > @@ -943,11 +938,6 @@ static int build_one_insn(const struct bpf_insn *insn, struct jit_ctx *ctx, > break; > case BPF_DIV: > case BPF_MOD: > - b_off = b_imm(exit_idx, ctx); > - if (is_bad_offset(b_off)) > - return -E2BIG; > - emit_instr(ctx, beq, src, MIPS_R_ZERO, b_off); > - emit_instr(ctx, movz, MIPS_R_V0, MIPS_R_ZERO, src); > emit_instr(ctx, divu, dst, src); > if (bpf_op == BPF_DIV) > emit_instr(ctx, mflo, dst); >