From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A19D298CAB; Sun, 31 May 2026 14:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780236351; cv=none; b=ndug2Tr4EoLbfHN8d6On2Ie9mHXmvnNBUmcthHe4mFH9LGapJkPLzjPqX8+ESbnKZmcGdisRq7a0SC+NybEStGHQ0S0vCeG8Ky8Oa5zRw0y+Y9OYxKkeS3/ss/exfpFiL4sGEe5IXUzVAid1Vdj+f39VOEDBQ02y64vi7Wlm/FY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780236351; c=relaxed/simple; bh=IOLIFZmEP3IECrC9peB0l1WsjtP4Y6z0haGq8mSpVeQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VX74QHO4sxU3PakSV9BVrlLthU3npy1t1lsIiABals2CO24etUQnEe7yW2+zqcCt2f+jbV+xUAtvnSuTmEFtfQUiOAGEtWWvVgYFWHN5sw9lHK06qYmAZbn/PP08k9lzzl3Rn3m6P3s+MKwRXz2M/PX2L7OyP5y/BOhnBfTd8g8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=q2aBrQl4; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="q2aBrQl4" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V4vbDh643123; Sun, 31 May 2026 14:04:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=MwHa5Q FcL7e+Jz9qqe6jS9Bm3L3BaWyTnC84DJoxaA0=; b=q2aBrQl4inBnbzCqSqjLab mjj+RWSzO3fbELVdYSZPv+4X0JzsCuCF1zbTCKtdt+EhIMjIgPsZxTrhBaMC6OyR +caZRR50xASV7W6mKeaCEKWzYUvN/FV7jCtVquwECOekX/xNx/85m5stOq8rpkYA TQDw2hpOqdX8V/wGrkaN574Iux1LUrQAzAUz0IMGe6Vx/1pAJJRjsJcZPxau7QJE z8jq09Krdc7iwQC035wpGMENV7XBvLmq+i6pOWp/n+VheMU4fwfEqieH5DjPgud0 XOQYBNDqzi3IA8ja5HbNjXdaNd78iPXO5bh6alXwU5AnlSsF7MqHWx9CFIXEfWuQ == Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4efqm4mqy5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 31 May 2026 14:04:19 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64VDs5gC000442; Sun, 31 May 2026 14:04:18 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4egakvj258-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 31 May 2026 14:04:18 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64VE3mdC22741648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 31 May 2026 14:03:48 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19C7E5804B; Sun, 31 May 2026 14:04:18 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A63458065; Sun, 31 May 2026 14:04:09 +0000 (GMT) Received: from [9.43.126.202] (unknown [9.43.126.202]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sun, 31 May 2026 14:04:08 +0000 (GMT) Message-ID: Date: Sun, 31 May 2026 19:34:07 +0530 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] selftests: mptcp: nvme: add iopolicy tests To: Geliang Tang , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Matthieu Baerts , Mat Martineau , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan Cc: Geliang Tang , linux-nvme@lists.infradead.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org, Hannes Reinecke , John Meneghini , Randy Jennings , zhenwei pi , Hui Zhu , Gang Yan References: <51f054a6a573b9a771ed927eef34fa5ca083d009.1779934709.git.tanggeliang@kylinos.cn> Content-Language: en-US From: Nilay Shroff In-Reply-To: <51f054a6a573b9a771ed927eef34fa5ca083d009.1779934709.git.tanggeliang@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: AR6tebVWWxaa8KQA2Bj_alLKaIjn9ftJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDE0OSBTYWx0ZWRfX9eY6H/WU7evb P6dYLt0y7NWx2mmmxuZwERJVcmkW5uCVvNpqHn/K2i/1un4rnlivdU+KfQzvIvsgAsGDJJ6+T// D0kgUJQEx7xTDqmZ9YQdgExxzoOR8L0a4rXIHNIzM5oZixme1m28DoIJnfIKYHY/f6Kamz+PbaF +JNjZEMYW/XLw4wnJ4+JhlA/2Zh/cE86tdv+LzcmLoFXXOCSNPCi0ot9ZUqt6wf3VUSEjB1EE1L MxLxDKA02VmGdg8ZPNufp1Us6IrgroS63P7wGzb+PKXXaceL+XauBs5cIc7TUSafocG4AOtXP4W ygjSLcvsM6/ZiIesPQRV3V0WVohrRGQsU0zfPmncv2gB6+PY5u55anouy2cFOAkyzZq5f7OmZZI +Kbwn4xfKUkEdSWwng7Eqv75DmazMqZSHKeF4DzBLwxHeBWwNJWKMAUuB/lL6ZPHJUgwAHG0g+k ci56E6gHCkGqGcxi1xg== X-Proofpoint-ORIG-GUID: TpB7akq0zrDzyrYNaSIZWiDiL28sXsxH X-Authority-Analysis: v=2.4 cv=Vf3H+lp9 c=1 sm=1 tr=0 ts=6a1c3fe4 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=c-RoEBXtFGQml9to_JoA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1011 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310149 On 5/28/26 8:40 AM, Geliang Tang wrote: > From: Geliang Tang > > Add NVMe iopolicy testing to mptcp_nvme.sh, with the default set to > "numa". It can be set to "round-robin" or "queue-depth". > > Test results with 4 NVMe multipath paths and round-robin iopolicy show > that TCP and MPTCP achieve similar bandwidth: > > # ./mptcp_nvme.sh tcp 4 round-robin > READ: bw=455MiB/s (478MB/s), 455MiB/s-455MiB/s (478MB/s-478MB/s), > io=4665MiB (4891MB), run=10242-10242msec > WRITE: bw=455MiB/s (477MB/s), 455MiB/s-455MiB/s (477MB/s-477MB/s), > io=4633MiB (4858MB), run=10184-10184msec > > # ./mptcp_nvme.sh mptcp 4 round-robin > READ: bw=445MiB/s (466MB/s), 445MiB/s-445MiB/s (466MB/s-466MB/s), > io=4575MiB (4797MB), run=10287-10287msec > WRITE: bw=445MiB/s (467MB/s), 445MiB/s-445MiB/s (467MB/s-467MB/s), > io=4572MiB (4794MB), run=10267-10267msec > > A "loss" argument is added to simulate network packet loss. When loss=1, > each veth interface is configured with "delay 5ms loss 0.5%" using tc > qdisc. Under this scenario, TCP performance is reduced by multiples > compared to MPTCP: > > # ./mptcp_nvme.sh tcp 4 round-robin 1 > READ: bw=144MiB/s (151MB/s), 144MiB/s-144MiB/s (151MB/s-151MB/s), > io=1909MiB (2001MB), run=13231-13231msec > WRITE: bw=100.0MiB/s (105MB/s), 100.0MiB/s-100.0MiB/s (105MB/s-105MB/s), > io=1397MiB (1465MB), run=13980-13980msec > > # ./mptcp_nvme.sh mptcp 4 round-robin 1 > READ: bw=428MiB/s (449MB/s), 428MiB/s-428MiB/s (449MB/s-449MB/s), > io=4524MiB (4743MB), run=10564-10564msec > WRITE: bw=431MiB/s (452MB/s), 431MiB/s-431MiB/s (452MB/s-452MB/s), > io=4513MiB (4732MB), run=10481-10481msec > > These results demonstrate that MPTCP has better resilience against > packet loss compared to TCP, as it can leverage multiple subflows to > mitigate network degradation. There are a few observations I'd like to raise: 1. It is difficult to reason about the throughput results when NVMe native multipath is enabled together with MPTCP. In this topology, four NVMe paths are created and the round-robin I/O policy is configured. As a result, each I/O first goes through the NVMe multipath scheduler, which selects a path, and is then further subjected to the MPTCP scheduler, which selects a TCP subflow. This means there are two independent schedulers influencing I/O placement, making it difficult to attribute the observed throughput improvements to either NVMe multipath or MPTCP. For throughput comparisons, it may be more meaningful to disable NVMe native multipath (e.g., modprobe nvme_core multipath=n) when testing MPTCP. This would ensure that all I/O is sent through a single NVMe/TCP path while allowing MPTCP alone to distribute traffic across available subflows. Such a setup would provide a clearer comparison between TCP and MPTCP. 2. The current test uses only a 128 KiB I/O size. It would be useful to include additional I/O sizes as well, such as 4 KiB, 8 KiB, and 32 KiB, since MPTCP and NVMe multipath may behave differently under different workload characteristics. 3. The fio runtime is only 10 seconds, which is relatively short for performance evaluation. The results may be influenced by startup transients and may not accurately reflect steady-state behavior. It would be preferable to run the tests for a longer duration, for example 120 seconds, to obtain more stable measurements. 4. The tests are run on the same host by setting up veth interfaces and running host and target under different network namespaces. It'd be useful if you could run this tests between real host and target systems. Thanks, --Nilay