From: Paolo Abeni <pabeni@redhat.com>
To: Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Neal Cardwell <ncardwell@google.com>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org, Taras Madan <tarasmadan@google.com>
Subject: Re: [PATCH v1 net] tcp: Don't call skb_clone_and_charge_r() for close()d listener in tcp_v6_do_rcv().
Date: Tue, 15 Sep 2026 15:13:01 +0200 [thread overview]
Message-ID: <d23fca29-243f-4c37-a846-e4c5c1dccd66@redhat.com> (raw)
In-Reply-To: <20260914011420.115556-1-kuniyu@google.com>
On 9/14/26 3:14 AM, Kuniyuki Iwashima wrote:
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index df9c29eb5c1f..7fa4ed2fd4f1 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1604,7 +1604,8 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
> by tcp. Feel free to propose better solution.
> --ANK (980728)
> */
> - if (np->rxopt.all && sk->sk_state != TCP_LISTEN)
> + if (np->rxopt.all &&
> + !((1 << sk->sk_state) & (TCPF_LISTEN | TCPF_CLOSE)))
> opt_skb = skb_clone_and_charge_r(skb, sk);
FTR clashiko thinks/laments that other states could be observed, but that
is a sloop. Apparently it can't digest commit 8cc3aef0cb19
/P
next prev parent reply other threads:[~2026-09-15 13:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 1:14 [PATCH v1 net] tcp: Don't call skb_clone_and_charge_r() for close()d listener in tcp_v6_do_rcv() Kuniyuki Iwashima
2026-09-14 8:53 ` Xuanqiang Luo
2026-09-14 10:30 ` Eric Dumazet
2026-09-15 1:15 ` netdev-bot+sashiko
2026-09-15 4:38 ` Kuniyuki Iwashima
2026-09-15 13:13 ` Paolo Abeni [this message]
2026-09-15 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d23fca29-243f-4c37-a846-e4c5c1dccd66@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=tarasmadan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox