netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Anjali Kulkarni <anjali.k.kulkarni@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Kuniyuki Iwashima <kuniyu@amazon.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/4] netlink: Move an assignment for the variable “cb_mutex” in __netlink_kernel_create()
Date: Sun, 31 Dec 2023 18:48:11 +0100	[thread overview]
Message-ID: <d250255b-fd88-4ea9-aa08-bc8d911143af@web.de> (raw)
In-Reply-To: <90679f69-951c-47b3-b86f-75fd9fde3da3@web.de>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 31 Dec 2023 18:16:26 +0100

Move one assignment for the variable “cb_mutex” closer to the place
where this pointer is used.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 net/netlink/af_netlink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index cfddc9c6a376..12a0b6f8be19 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2019,7 +2019,7 @@ __netlink_kernel_create(struct net *net, int unit, struct module *module,
 	struct sock *sk;
 	struct netlink_sock *nlk;
 	struct listeners *listeners;
-	struct mutex *cb_mutex = cfg ? cfg->cb_mutex : NULL;
+	struct mutex *cb_mutex; /* Serialize data processing with callbacks */
 	unsigned int groups;

 	BUG_ON(!nl_table);
@@ -2030,6 +2030,7 @@ __netlink_kernel_create(struct net *net, int unit, struct module *module,
 	if (sock_create_lite(PF_NETLINK, SOCK_DGRAM, unit, &sock))
 		return NULL;

+	cb_mutex = (cfg ? cfg->cb_mutex : NULL);
 	if (__netlink_create(net, sock, cb_mutex, unit, 1) < 0)
 		goto out_sock_release_nosk;

--
2.43.0


  parent reply	other threads:[~2023-12-31 17:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31 17:40 [PATCH 0/4] netlink: Adjustments for __netlink_kernel_create() Markus Elfring
2023-12-31 17:42 ` [PATCH 1/4] netlink: Improve exception handling in __netlink_kernel_create() Markus Elfring
2024-01-01 18:13   ` Stephen Hemminger
2023-12-31 17:44 ` [PATCH 2/4] netlink: Move an assignment for the variable “sk” " Markus Elfring
2024-01-01  0:54   ` kernel test robot
2024-01-01 10:22     ` Markus Elfring
2024-01-01 18:14   ` Stephen Hemminger
2023-12-31 17:46 ` [PATCH 3/4] netlink: Delete an unnecessary variable initialisation " Markus Elfring
2024-01-01 18:42   ` Stephen Hemminger
2023-12-31 17:48 ` Markus Elfring [this message]
2024-01-01 18:18   ` [PATCH 4/4] netlink: Move an assignment for the variable “cb_mutex” " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d250255b-fd88-4ea9-aa08-bc8d911143af@web.de \
    --to=markus.elfring@web.de \
    --cc=anjali.k.kulkarni@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).