From: Andrew Lunn <andrew@lunn.ch>
To: Yongzhao Chen <yongzhao.derek@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Vladimir Oltean <olteanv@gmail.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Ziyang Huang <hzyitc@outlook.com>
Subject: Re: [RFC PATCH net-next v3 4/5] net: dsa: qca8k: flag QCA8337 internal CPU PHYs for SmartSpeed
Date: Fri, 25 Sep 2026 17:17:33 +0200 [thread overview]
Message-ID: <d2797713-9b92-43c8-a26e-bf3bc9817ad8@lunn.ch> (raw)
In-Reply-To: <20260924234814.1734-1-yongzhao.derek@gmail.com>
> I don't know whether downshift is broken in general or only in
> switch-integrated PHYs. My only data point is the RA74 CPU link
> failure, and I have no downshift results from user ports or discrete
> at803x PHYs.
It is pretty easy to test, if you have a spare Ethernet cable you can
sacrifice.
https://en.wikipedia.org/wiki/Ethernet_over_twisted_pair
100Mbps needs pins 1-4, 5-8 are not used. So you can either cover some
of those pins with something, maybe nail varnish, or take some of the
outer cover off the cable to expose the wires, and if it follows the
colour scheme describe cut say the brown cable.
But this is testing the wrong thing. This is testing downshift
works. What you are actually interested in is downshift happening when
it should not....
So take a closer look at the user ports. phylib should report when a
downshift occurs:
https://elixir.bootlin.com/linux/v7.2.7/source/drivers/net/phy/phy-core.c#L359
phydev->advertising should contain what the user configured, even if
the hardware has cleared the 1G advertisement. So it should trigger.
Andrew
next prev parent reply other threads:[~2026-09-25 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 21:58 [RFC PATCH net-next v3 0/5] net: dsa: qca8k: add a QCA8337 CPU PHY consumer Yongzhao Chen
2026-09-23 21:58 ` [RFC PATCH net-next v3 1/5] net: dsa: pass PHY flags when connecting shared ports Yongzhao Chen
2026-09-23 21:58 ` [RFC PATCH net-next v3 2/5] net: dsa: qca8k: serialize CPU MAC pause during MTU changes Yongzhao Chen
2026-09-23 21:58 ` [RFC PATCH net-next v3 3/5] net: dsa: qca8k: support QCA8337 internal PHY CPU links Yongzhao Chen
2026-09-23 21:58 ` [RFC PATCH net-next v3 4/5] net: dsa: qca8k: flag QCA8337 internal CPU PHYs for SmartSpeed Yongzhao Chen
2026-09-24 2:51 ` Andrew Lunn
2026-09-24 23:48 ` Yongzhao Chen
2026-09-25 15:17 ` Andrew Lunn [this message]
2026-09-25 21:01 ` Yongzhao Chen
2026-09-25 21:26 ` Andrew Lunn
2026-09-26 8:21 ` Yongzhao Chen
2026-09-26 13:11 ` Andrew Lunn
2026-09-26 21:51 ` Yongzhao Chen
2026-09-27 14:48 ` Andrew Lunn
2026-09-27 15:36 ` Yongzhao Chen
2026-09-28 6:57 ` Yongzhao Chen
2026-09-28 12:40 ` Andrew Lunn
2026-09-27 8:05 ` Ziyang Huang
2026-09-27 15:35 ` Yongzhao Chen
2026-09-23 21:58 ` [RFC PATCH net-next v3 5/5] net: phy: qca83xx: disable SmartSpeed before resetting CPU PHYs Yongzhao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2797713-9b92-43c8-a26e-bf3bc9817ad8@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=hzyitc@outlook.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=yongzhao.derek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox