From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BAA63D6CA4 for ; Mon, 4 May 2026 15:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777906924; cv=none; b=T6fDrNca8GPmPBNS1ypqkYXKC5zQRjvVqy9q5oFqiE0uDD7qIBuhp4d29Uo45JftSWo3N19yO898xttgr6TOv3eUydnxu+/bmo4KstbU8ZItn+anoJTpgKB6abngl58tR55XV05CdQse+rt1VagWs98ZgkL0Z2xyPZ5HPJp5OLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777906924; c=relaxed/simple; bh=gHEEu3i2lAtUdjFzSmA8zzRy2/2/gwHXx0B3ugYNibc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ceGi4zDFiGkLSZLTrWBVxmyCdL3T2saDqHYjHGqGYgChhcZSAbleVEsydvNUSTKOZHBhCWylShYrQSuPSvNlB9ZmkuAkFSh1qAa0PYI1gsQM+CjIGwn4CUXJm23vdbmX5NS9pLb8KvuXyZT84zbaF/r7uJf9fxH+34Otmj+PaZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=bSrjcPlR; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=K4mUmkz8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=lagbQCMn; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=072XkwW4; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bSrjcPlR"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="K4mUmkz8"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="lagbQCMn"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="072XkwW4" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C8B2C6B348; Mon, 4 May 2026 15:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777906916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QzXieXDgOJjo8lmnMnCqsJRnjai8Jc2VOGJUwi7SIl4=; b=bSrjcPlR4q/a8r6B/EEPlXO1Mvp+wQaDUdEC2zSp5QcFmI3MbK6dLNrqCXg8ydj+IPUXnF 534LOqknEbqAsM9Ep6CNAbTfDt/y4rENuXM1sRp74vxDTKx5h9Ie8bQCDEmya1fa72IrnM 7ULpf/dZtN+6H0MAQRB3BfteHTc8foU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777906916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QzXieXDgOJjo8lmnMnCqsJRnjai8Jc2VOGJUwi7SIl4=; b=K4mUmkz8uhtvO3nqvImnUPqHI59bnGwGbINxtxklHI152BIFjXz24a4td5S7RBxJDOTclz 196tNb7QlT3bx1Ag== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=lagbQCMn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=072XkwW4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777906911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QzXieXDgOJjo8lmnMnCqsJRnjai8Jc2VOGJUwi7SIl4=; b=lagbQCMnOh4IJMSRdsfdyNHzcMOn7YEYyDnZp35W/dS8IUMO9V5OZ2ioBUYwozBhEdfuFn 5+4vafjWIcmNFm/lGKp/IiRTp4c/+V18LNDcv8/RCCdC28jsH7LA6JghLY5dv+nJi0+Ox2 UMTe6pEGzWp5Grlx3BSQV7R3pAj1Ks4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777906911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QzXieXDgOJjo8lmnMnCqsJRnjai8Jc2VOGJUwi7SIl4=; b=072XkwW4ZYiMOk+eEVCKvvBrKxlRauIep5SX1Wq2RWJx0fG1v384ITfXNuHF8vIHxgUInQ gn1PAaxFQaYPUhAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3309C593A3; Mon, 4 May 2026 15:01:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id g0uKCd+0+GnDeAAAD6G6ig (envelope-from ); Mon, 04 May 2026 15:01:51 +0000 Message-ID: Date: Mon, 4 May 2026 17:01:43 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ipv6: default IPV6_SIT to m To: Alyssa Ross , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Ricardo_B_=2E_Marli=C3=A8re?= , Krzysztof Kozlowski References: <20260503192515.290900-2-hi@alyssa.is> <5f676587-fcdd-4704-9523-07a7fd98455a@suse.de> <878q9zdz6s.fsf@alyssa.is> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <878q9zdz6s.fsf@alyssa.is> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[alyssa.is:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; RSPAMD_EMAILBL_FAIL(0.00)[hi.alyssa.is:query timed out]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,alyssa.is:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Queue-Id: C8B2C6B348 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: On 5/4/26 4:30 PM, Alyssa Ross wrote: > Fernando Fernandez Mancera writes: > >> On 5/3/26 9:25 PM, Alyssa Ross wrote: >>> This basically defaulted to m until recently, since IPV6 defaulted to >>> m. Since IPV6 was changed to a boolean with a default of y, IPV6_SIT >>> started defaulting to built-in as well. This results in a surprise >>> sit0 device by default for defconfig (and defconfig-derived config) >>> users at boot. For me, this broke an (admittedly non-robust) script. >>> Preserve the behaviour of most configs by avoiding building this >>> module, that's probably overall seldom used compared to IPv6 as a >>> whole, into the kernel. >>> >>> Fixes: 309b905deee59 ("ipv6: convert CONFIG_IPV6 to built-in only and clean up Kconfigs") >>> Signed-off-by: Alyssa Ross >> >> Hi, I am not sure about this. IPV6_SIT was already defaulting to 'y' for >> most distributions (except for ARM). Sure, if you had CONFIG_IPV6=m then >> CONFIG_IPV6_SIT was defaulting to 'm'. >> >> Hm. Maybe we can aim this for net-next tree instead of net? I just don't >> think this is a fix but a change in behavior. FWIW, it makes sense to me >> to have this as a module by default. >> >> Let's see what do others think. > > Yes, it appears you're right. I had only tested on ARM. In that case, > perhaps it make sense to instead set this to m in the arm64 defconfig, to > preserve the previous situation, but I can also see the value in > reducing platform discongruity by letting it change to y on arm64 too. Changing it on arm64 defconfig would make sense to me too. We should probably visit other configs that might be in the same situation. That in my opinion would qualify a net tree fix as you proposed initially.