From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesus Sanchez-Palencia Subject: Re: [PATCH v1 net-next 13/14] net/sched: Enforce usage of CLOCK_TAI for sch_etf Date: Thu, 28 Jun 2018 10:11:39 -0700 Message-ID: References: <20180627215950.6719-1-jesus.sanchez-palencia@intel.com> <20180627215950.6719-14-jesus.sanchez-palencia@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Network Development , Thomas Gleixner , jan.altenberg@linutronix.de, Vinicius Gomes , kurt.kanzenbach@linutronix.de, Henrik Austad , Richard Cochran , ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, Miroslav Lichvar , Willem de Bruijn , Jamal Hadi Salim , Cong Wang , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= To: Willem de Bruijn Return-path: Received: from mga18.intel.com ([134.134.136.126]:36351 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932186AbeF1RQd (ORCPT ); Thu, 28 Jun 2018 13:16:33 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/28/2018 07:26 AM, Willem de Bruijn wrote: > On Wed, Jun 27, 2018 at 8:45 PM Jesus Sanchez-Palencia > wrote: >> >> The qdisc and the SO_TXTIME ABIs allow for a clockid to be configured, >> but it's been decided that usage of CLOCK_TAI should be enforced until >> we decide to allow for other clockids to be used. The rationale here is >> that PTP times are usually in the TAI scale, thus no other clocks should >> be necessary. >> >> For now, the qdisc will return EINVAL if any clocks other than >> CLOCK_TAI are used. >> >> Signed-off-by: Jesus Sanchez-Palencia >> --- >> net/sched/sch_etf.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c >> index cd6cb5b69228..5514a8aa3bd5 100644 >> --- a/net/sched/sch_etf.c >> +++ b/net/sched/sch_etf.c >> @@ -56,8 +56,8 @@ static inline int validate_input_params(struct tc_etf_qopt *qopt, >> return -ENOTSUPP; >> } >> >> - if (qopt->clockid >= MAX_CLOCKS) { >> - NL_SET_ERR_MSG(extack, "Invalid clockid"); >> + if (qopt->clockid != CLOCK_TAI) { >> + NL_SET_ERR_MSG(extack, "Invalid clockid. CLOCK_TAI must be used"); > > Similar to the comment in patch 12, this should be squashed (into > patch 6) to avoid incorrect behavior in a range of SHA1s. Ok. Fixed for v2. Thanks, Jesus