From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe ROULLIER Subject: RE: [PATCH V2 8/8] dt-bindings: stm32: add compatible for syscon Date: Tue, 15 May 2018 16:19:53 +0000 Message-ID: References: <1525270723-18241-1-git-send-email-christophe.roullier@st.com> <1525270723-18241-9-git-send-email-christophe.roullier@st.com> <20180507163537.GA15212@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "mark.rutland@arm.com" , "andrew@lunn.ch" , Alexandre TORGUE , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "mcoquelin.stm32@gmail.com" , Peppe CAVALLARO , "linux-arm-kernel@lists.infradead.org" To: Rob Herring Return-path: In-Reply-To: <20180507163537.GA15212@rob-hp-laptop> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org Hi Rob, I do not understand, so let me explain our status: We have syscfg IP Harware in our SOC. But we do not have SoC specific driver to manage syscfg, we are using a generic driver "syscon". So can you tell me what you wish to describe this part in our SOC bindings ? Thanks for your help. Christophe. -----Original Message----- From: Rob Herring [mailto:robh@kernel.org] Sent: lundi 7 mai 2018 18:36 To: Christophe ROULLIER Cc: mark.rutland@arm.com; mcoquelin.stm32@gmail.com; Alexandre TORGUE ; Peppe CAVALLARO ; devicetree@vger.kernel.org; andrew@lunn.ch; linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org Subject: Re: [PATCH V2 8/8] dt-bindings: stm32: add compatible for syscon On Wed, May 02, 2018 at 04:18:43PM +0200, Christophe Roullier wrote: > This patch describes syscon DT bindings. > > Signed-off-by: Christophe Roullier > --- > Documentation/devicetree/bindings/arm/stm32.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/stm32.txt > b/Documentation/devicetree/bindings/arm/stm32.txt > index 6808ed9..06e3834 100644 > --- a/Documentation/devicetree/bindings/arm/stm32.txt > +++ b/Documentation/devicetree/bindings/arm/stm32.txt > @@ -8,3 +8,7 @@ using one of the following compatible strings: > st,stm32f746 > st,stm32h743 > st,stm32mp157 > + > +Required nodes: > +- syscon: the soc bus node must have a system controller node > +pointing to the > + global control registers, with the compatible string "syscon"; You misunderstood my prior comment. 'syscon' alone is not valid. You need SoC specific compatible string for it and 'stm32' is not SoC specific. IOW, the compatible property for a syscon should imply every single register field in the block. Rob