Netdev List
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH net v5] net: txgbe: fix stack size for PHY interface mask
Date: Sun, 22 Nov 2026 18:50:38 +0100	[thread overview]
Message-ID: <d2b855a2-ee88-4670-877a-49226e6f9ae4@bootlin.com> (raw)
In-Reply-To: <20261117175528.3018609-1-coiaprant@gmail.com>

Hi Coia,

On 11/17/26 18:55, Coia Prant wrote:
> The DECLARE_PHY_INTERFACE_MASK_ZERO() macro currently defined in the
> txgbe driver incorrectly uses PHY_INTERFACE_MODE_MAX as the array
> length instead of BITS_TO_LONGS(). This allocates significantly more
> space on the stack than necessary.
> 
> Since hiding the zero-initialization inside a macro is discouraged,
> drop the local macro entirely and use the standard
> DECLARE_PHY_INTERFACE_MASK() with explicit zero-initialization at the
> declaration site instead.
> 
> Fixes: 47f848aac4e7 ("net: txgbe: initialize PHY interface to 0")
> Signed-off-by: Coia Prant <coiaprant@gmail.com>
> Cc: Jiawen Wu <jiawenwu@trustnetic.com>

I'm OK with the patch itself, but that should go to net-next.

Please resent there, feel free to add

  Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime


      parent reply	other threads:[~2026-11-22 17:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:55 [PATCH net v5] net: txgbe: fix stack size for PHY interface mask Coia Prant
2026-11-17 17:57 ` netdev-bot+sinfo
2026-11-22 17:50 ` Maxime Chevallier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2b855a2-ee88-4670-877a-49226e6f9ae4@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox