From: Andrew Lunn <andrew@lunn.ch>
To: Guru Das Srinagesh <linux@gurudas.dev>
Cc: FUJITA Tomonori <fujita.tomonori@gmail.com>,
Trevor Gross <tmgross@umich.edu>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style
Date: Mon, 6 Jul 2026 15:58:13 +0200 [thread overview]
Message-ID: <d2c1e11e-e616-4b2f-aa17-5eb96f045833@lunn.ch> (raw)
In-Reply-To: <20260705-net-vert-imp-v1-2-95a35ddff411@gurudas.dev>
On Sun, Jul 05, 2026 at 10:38:41PM -0700, Guru Das Srinagesh wrote:
> Convert `use` imports to vertical layout for better readability and
> maintainability.
>
> Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
> ---
> drivers/net/phy/qt2025.rs | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
> index 470d89a0ac00..efde3f909367 100644
> --- a/drivers/net/phy/qt2025.rs
> +++ b/drivers/net/phy/qt2025.rs
> @@ -14,11 +14,17 @@
> use kernel::io::poll::read_poll_timeout;
> use kernel::net::phy::{
> self,
> - reg::{Mmd, C45},
> + reg::{
> + Mmd,
> + C45, //
> + },
Given the comment this should be sorted in 'ASCIIbetical order',
isn't this wrong, C comes before M?
Andrew
next prev parent reply other threads:[~2026-07-06 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 5:38 [PATCH net-next 0/2] rust: net: Use kernel style vertical imports Guru Das Srinagesh
2026-07-06 5:38 ` [PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style Guru Das Srinagesh
2026-07-06 13:05 ` Andrew Lunn
2026-07-06 13:40 ` Gary Guo
2026-07-06 13:53 ` Andrew Lunn
2026-07-06 13:45 ` Alice Ryhl
2026-07-06 5:38 ` [PATCH net-next 2/2] net: phy: qt2025: " Guru Das Srinagesh
2026-07-06 13:58 ` Andrew Lunn [this message]
2026-07-06 15:07 ` Gary Guo
2026-07-06 15:28 ` Miguel Ojeda
2026-07-06 15:51 ` Andrew Lunn
2026-07-06 16:08 ` Miguel Ojeda
2026-07-06 16:15 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c1e11e-e616-4b2f-aa17-5eb96f045833@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@gurudas.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox