From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Network Development" <netdev@vger.kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <rmk+kernel@armlinux.org.uk>
Subject: Re: Race between "Generic PHY" and "bcm53xx" drivers after -EPROBE_DEFER
Date: Mon, 20 Sep 2021 11:25:06 -0700 [thread overview]
Message-ID: <d2c7a300-656f-ffec-fb14-2b4e99f28081@gmail.com> (raw)
In-Reply-To: <20210920181727.al66xrvjmgqwyuz2@skbuf>
On 9/20/21 11:17 AM, Vladimir Oltean wrote:
[snip]
>> All I am saying is that there is not really any need to come up with a
>> Device Tree-based solution since you can inspect the mdio_device and
>> find out whether it is an Ethernet PHY or a MDIO device proper, and that
>> ought to cover all cases that I can think of.
>
> Okay, but where's the problem? I guess we're on the same page, and
> you're saying that we should not be calling bcma_mdio_mii_register, and
> assigning the result to bgmac->mii_bus, because that makes us call
> bcma_phy_connect instead of bgmac_phy_connect_direct. But based on what
> condition? Simply if bgmac->phyaddr == BGMAC_PHY_NOREGS?
Yes simply that condition, I really believe it ought to be enough for
the space these devices are in use.
--
Florian
next prev parent reply other threads:[~2021-09-21 2:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:52 Race between "Generic PHY" and "bcm53xx" drivers after -EPROBE_DEFER Rafał Miłecki
2021-09-20 16:36 ` Florian Fainelli
2021-09-20 17:03 ` Vladimir Oltean
2021-09-20 17:14 ` Florian Fainelli
2021-09-20 17:40 ` Vladimir Oltean
2021-09-20 17:46 ` Florian Fainelli
2021-09-20 18:02 ` Vladimir Oltean
2021-09-20 18:10 ` Florian Fainelli
2021-09-20 18:17 ` Vladimir Oltean
2021-09-20 18:25 ` Florian Fainelli [this message]
2021-09-20 18:36 ` Vladimir Oltean
2021-09-21 9:45 ` Rafał Miłecki
2021-09-21 10:52 ` Rafał Miłecki
2021-09-20 18:58 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c7a300-656f-ffec-fb14-2b4e99f28081@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).