From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EBCC169C4 for ; Thu, 31 Jan 2019 05:12:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B9C52184D for ; Thu, 31 Jan 2019 05:12:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vK1FR39h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725885AbfAaFMt (ORCPT ); Thu, 31 Jan 2019 00:12:49 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:42488 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbfAaFMs (ORCPT ); Thu, 31 Jan 2019 00:12:48 -0500 Received: by mail-pl1-f196.google.com with SMTP id y1so940788plp.9 for ; Wed, 30 Jan 2019 21:12:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9xDUKpRYq4xkaavsxOm2bf1jdGVlNopc/VEm3SAXsuI=; b=vK1FR39haCB3csZMV4sw2lMQvCGIzrt14YFdWs5O44kGxmNHwekYNxdWs4baQCaPga i8cuDtqEzHumW7lNK5f6XrQQQhLsZP/yt9rVQNZDqUhXZmyXApyOEmZdqYro987bDItN +8lCepjWE+EbHOXh/+muz8d7tMDnMDaqoN9ihs/e5i1IL8WbFDjNRzWn/J+oUUzTGZWc VD+Ey++RU9r7iZ5eCPJI2a8AjDkh+jBMepzZGxTJZDb7KSmtIW0fbSvUV338HFCi32q6 TSvgsWTYJaVIIoFc6ZApDq0eZ1e25Kmo+UHdC0aVEQVggf13nrNU17cgBEThHwojq20R 0hPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9xDUKpRYq4xkaavsxOm2bf1jdGVlNopc/VEm3SAXsuI=; b=XNovtWgAvSXM352kFqgaLxGS82aIP188sxrBLkMtDh49eKKj/gnvwOCUGjxvVF8Gff W1JJU34vaQCTcUd1KeDbZZJ7KsAcIuZh2Haxx9rBw8/8LlvcLILf6f6WTuWeZ28VQYWW 9Gu48WUWoIB0vgPDZDjcb7seQhuG2s91QYykKB6YUzn/4RMI2atcW1mJ1/FG5MXP5lJb IwRSDnkGe5esd0WG0hESV3bsxqgbYGApwt14MIhroSiV7RCxyEZQGRWdc3AvvxBqMyHu bc57mf6efUo35El76wMdfgyyG+lFxGJUSFGdYM/HoeC88kpLQPmJS2L5oYQc2zdi1Y2d chOw== X-Gm-Message-State: AJcUukcronffZwJyAH0jm7DjnDc2dUZIACUk9/gUBPsFETHdfCoUjZVT R2ZjeU8XxjH4OFLAQdZLuN/b3Prv X-Google-Smtp-Source: ALg8bN5frc07AFuqhmg6NfMkn53VXQpMrghXSggkbtV5JsOnHHLDVsQVqH/IINqc336mHyrKkbbsDg== X-Received: by 2002:a17:902:ac8f:: with SMTP id h15mr32300845plr.245.1548911567629; Wed, 30 Jan 2019 21:12:47 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:9dc2:62ad:d8b0:5eeb? ([2601:282:800:fd80:9dc2:62ad:d8b0:5eeb]) by smtp.googlemail.com with ESMTPSA id n78sm5524338pfk.19.2019.01.30.21.12.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 21:12:46 -0800 (PST) Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script To: Stefano Brivio Cc: Phil Sutter , Eric Garver , Tomas Dolezal , Stephen Hemminger , Lennert Buytenhek , netdev@vger.kernel.org References: <8b930eb8-6ffe-d03f-02a3-12a332edbba3@gmail.com> <20190130115555.61868ab9@redhat.com> From: David Ahern Message-ID: Date: Wed, 30 Jan 2019 22:12:45 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190130115555.61868ab9@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/30/19 3:55 AM, Stefano Brivio wrote: >> I get your intent, but this seems more appropriate for you / Red Hat to >> carry than something we want to distribute as part of iproute2. > > Sure, I could also do that, but: > > - me creating another project: similar maintenance burden for > distribution maintainers as keeping bridge-utils around, > for something that won't have any active development > > - carrying it in a single distribution downstream: I would have gone > that way if I thought it wouldn't be useful for others. I myself use > (also) distributions other than Fedora/RHEL and this would feel > just... wrong > > Why do you think it's not appropriate to distribute this as part of > iproute2? Too ugly? Bloated? Anything I can improve? > > I think it would be appropriate because it intimately depends on > ip-link -- it's really nothing more than a helper for iproute2 tools. > Again, I understand your point ... I still, too often, type ifconfig from long in-grained muscle memory. This is a convenience wrapper around commands packaged in iproute2. If iproute2 adds this wrapper, it will have to carry it and maintain it forever. Distributions (Fedora, RHEL, Debian, etc) may see it differently and decide to add this patch onto iproute2 that they distribute as a means for dropping bridge-utils. That's a reasonable migration choice. It is just not something upstream iproute2 should carry.