Netdev List
 help / color / mirror / Atom feed
From: Yuehaibing <yuehaibing@huawei.com>
To: <pablo@netfilter.org>, <kadlec@blackhole.kfki.hu>, <fw@strlen.de>,
	<davem@davemloft.net>, <rdunlap@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <coreteam@netfilter.org>,
	<netfilter-devel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] netfilter: ipv6: Fix build error without CONFIG_IPV6
Date: Thu, 20 Jun 2019 23:26:01 +0800	[thread overview]
Message-ID: <d2eba9e4-34be-f9bb-f0fd-024fe81d2b02@huawei.com> (raw)
In-Reply-To: <20190612084715.21656-1-yuehaibing@huawei.com>

Friendly ping...

On 2019/6/12 16:47, YueHaibing wrote:
> If CONFIG_IPV6 is not set, building fails:
> 
> net/bridge/netfilter/nf_conntrack_bridge.o: In function `nf_ct_bridge_pre':
> nf_conntrack_bridge.c:(.text+0x41c): undefined symbol `nf_ct_frag6_gather'
> net/bridge/netfilter/nf_conntrack_bridge.o: In function `nf_ct_bridge_post':
> nf_conntrack_bridge.c:(.text+0x820): undefined symbol `br_ip6_fragment'
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: c9bb6165a16e ("netfilter: nf_conntrack_bridge: fix CONFIG_IPV6=y")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  include/linux/netfilter_ipv6.h | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/netfilter_ipv6.h b/include/linux/netfilter_ipv6.h
> index 3a3dc4b..0e1febc 100644
> --- a/include/linux/netfilter_ipv6.h
> +++ b/include/linux/netfilter_ipv6.h
> @@ -108,8 +108,11 @@ static inline int nf_ipv6_br_defrag(struct net *net, struct sk_buff *skb,
>  		return 1;
>  
>  	return v6_ops->br_defrag(net, skb, user);
> -#else
> +#endif
> +#if IS_BUILTIN(CONFIG_IPV6)
>  	return nf_ct_frag6_gather(net, skb, user);
> +#else
> +	return 1;
>  #endif
>  }
>  
> @@ -133,8 +136,11 @@ static inline int nf_br_ip6_fragment(struct net *net, struct sock *sk,
>  		return 1;
>  
>  	return v6_ops->br_fragment(net, sk, skb, data, output);
> -#else
> +#endif
> +#if IS_BUILTIN(CONFIG_IPV6)
>  	return br_ip6_fragment(net, sk, skb, data, output);
> +#else
> +	return 1;
>  #endif
>  }
>  
> 


  reply	other threads:[~2019-06-20 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  8:47 [PATCH net-next] netfilter: ipv6: Fix build error without CONFIG_IPV6 YueHaibing
2019-06-20 15:26 ` Yuehaibing [this message]
2019-06-20 15:50   ` Pablo Neira Ayuso
2019-06-21  2:05     ` Yuehaibing
2019-06-21 15:20       ` Pablo Neira Ayuso
2019-06-21 15:16 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2eba9e4-34be-f9bb-f0fd-024fe81d2b02@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox