From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yonghong Song Subject: Re: [PATCH bpf-next 05/13] bpf: get better bpf_prog ksyms based on btf func type_id Date: Wed, 17 Oct 2018 03:24:25 +0000 Message-ID: References: <20181012185446.2379289-1-yhs@fb.com> <20181016175901.vninfgdsjtizssvt@ast-mbp.dhcp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Alexei Starovoitov , Martin Lau , "daniel@iogearbox.net" , "netdev@vger.kernel.org" , Kernel Team To: Alexei Starovoitov Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:34716 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbeJQLSs (ORCPT ); Wed, 17 Oct 2018 07:18:48 -0400 In-Reply-To: <20181016175901.vninfgdsjtizssvt@ast-mbp.dhcp.thefacebook.com> Content-Language: en-US Content-ID: <8A12B906DB0C084ABDEEEDE4A2F160DD@namprd15.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: DQoNCk9uIDEwLzE2LzE4IDEwOjU5IEFNLCBBbGV4ZWkgU3Rhcm92b2l0b3Ygd3JvdGU6DQo+IE9u IEZyaSwgT2N0IDEyLCAyMDE4IGF0IDExOjU0OjQyQU0gLTA3MDAsIFlvbmdob25nIFNvbmcgd3Jv dGU6DQo+PiBUaGlzIHBhdGNoIGFkZGVkIGludGVyZmFjZSB0byBsb2FkIGEgcHJvZ3JhbSB3aXRo IHRoZSBmb2xsb3dpbmcNCj4+IGFkZGl0aW9uYWwgaW5mb3JtYXRpb246DQo+PiAgICAgLiBwcm9n X2J0Zl9mZA0KPj4gICAgIC4gZnVuY19pbmZvIGFuZCBmdW5jX2luZm9fbGVuDQo+PiB3aGVyZSBm dW5jX2luZm8gd2lsbCBwcm92aWRlcyBmdW5jdGlvbiByYW5nZSBhbmQgdHlwZV9pZA0KPj4gY29y cmVzcG9uZGluZyB0byBlYWNoIGZ1bmN0aW9uLg0KPj4NCj4+IElmIHZlcmlmaWVyIGFncmVlcyB3 aXRoIGZ1bmN0aW9uIHJhbmdlIHByb3ZpZGVkIGJ5IHRoZSB1c2VyLA0KPj4gdGhlIGJwZl9wcm9n IGtzeW0gZm9yIGVhY2ggZnVuY3Rpb24gd2lsbCB1c2UgdGhlIGZ1bmMgbmFtZQ0KPj4gcHJvdmlk ZWQgaW4gdGhlIHR5cGVfaWQsIHdoaWNoIGlzIHN1cHBvc2VkIHRvIHByb3ZpZGUgYmV0dGVyDQo+ PiBlbmNvZGluZyBhcyBpdCBpcyBub3QgbGltaXRlZCBieSAxNiBieXRlcyBwcm9ncmFtIG5hbWUN Cj4+IGxpbWl0YXRpb24gYW5kIHRoaXMgaXMgYmV0dGVyIGZvciBicGYgcHJvZ3JhbSB3aGljaCBj b250YWlucw0KPj4gbXVsdGlwbGUgc3VicHJvZ3JhbXMuDQo+Pg0KPj4gVGhlIGJwZl9wcm9nX2lu Zm8gaW50ZXJmYWNlIGlzIGFsc28gZXh0ZW5kZWQgdG8NCj4+IHJldHVybiBidGZfaWQgYW5kIGpp dGVkX2Z1bmNfdHlwZXMsIHNvIHVzZXIgc3BhY2VzIGNhbg0KPj4gcHJpbnQgb3V0IHRoZSBmdW5j dGlvbiBwcm90b3R5cGUgZm9yIGVhY2ggaml0ZWQgZnVuY3Rpb24uDQo+Pg0KPj4gU2lnbmVkLW9m Zi1ieTogWW9uZ2hvbmcgU29uZyA8eWhzQGZiLmNvbT4NCj4gLi4uDQo+PiAgIAlCVUlMRF9CVUdf T04oc2l6ZW9mKCJicGZfcHJvZ18iKSArDQo+PiAgIAkJICAgICBzaXplb2YocHJvZy0+dGFnKSAq IDIgKw0KPj4gQEAgLTQwMSw2ICs0MDMsMTMgQEAgc3RhdGljIHZvaWQgYnBmX2dldF9wcm9nX25h bWUoY29uc3Qgc3RydWN0IGJwZl9wcm9nICpwcm9nLCBjaGFyICpzeW0pDQo+PiAgIA0KPj4gICAJ c3ltICs9IHNucHJpbnRmKHN5bSwgS1NZTV9OQU1FX0xFTiwgImJwZl9wcm9nXyIpOw0KPj4gICAJ c3ltICA9IGJpbjJoZXgoc3ltLCBwcm9nLT50YWcsIHNpemVvZihwcm9nLT50YWcpKTsNCj4+ICsN Cj4+ICsJaWYgKHByb2ctPmF1eC0+YnRmKSB7DQo+PiArCQlmdW5jX25hbWUgPSBidGZfZ2V0X25h bWVfYnlfaWQocHJvZy0+YXV4LT5idGYsIHByb2ctPmF1eC0+dHlwZV9pZCk7DQo+PiArCQlzbnBy aW50ZihzeW0sIChzaXplX3QpKGVuZCAtIHN5bSksICJfJXMiLCBmdW5jX25hbWUpOw0KPj4gKwkJ cmV0dXJuOw0KPiANCj4gV291bGQgaXQgbWFrZSBzZW5zZSB0byBhZGQgYSBjb21tZW50IGhlcmUg dGhhdCBwcm9nLT5hdXgtPm5hbWUgaXMgaWdub3JlZA0KPiB3aGVuIGZ1bGwgYnRmIG5hbWUgaXMg YXZhaWxhYmxlPyAob3RoZXJ3aXNlIHRoZSBzYW1lIG5hbWUgd2lsbCBhcHBlYXIgdHdpY2UgaW4g a3N5bSkNCg0KV2lsbCBhZGQgYSBjb21tZW50Lg0KDQo+IA0KPj4gKwl9DQo+PiArDQo+PiAgIAlp ZiAocHJvZy0+YXV4LT5uYW1lWzBdKQ0KPj4gICAJCXNucHJpbnRmKHN5bSwgKHNpemVfdCkoZW5k IC0gc3ltKSwgIl8lcyIsIHByb2ctPmF1eC0+bmFtZSk7DQo+IC4uLg0KPj4gK3N0YXRpYyBpbnQg Y2hlY2tfYnRmX2Z1bmMoc3RydWN0IGJwZl9wcm9nICpwcm9nLCBzdHJ1Y3QgYnBmX3ZlcmlmaWVy X2VudiAqZW52LA0KPj4gKwkJCSAgdW5pb24gYnBmX2F0dHIgKmF0dHIpDQo+PiArew0KPj4gKwlz dHJ1Y3QgYnBmX2Z1bmNfaW5mbyAqZGF0YTsNCj4+ICsJaW50IGksIG5mdW5jcywgcmV0ID0gMDsN Cj4+ICsNCj4+ICsJaWYgKCFhdHRyLT5mdW5jX2luZm9fbGVuKQ0KPj4gKwkJcmV0dXJuIDA7DQo+ PiArDQo+PiArCW5mdW5jcyA9IGF0dHItPmZ1bmNfaW5mb19sZW4gLyBzaXplb2Yoc3RydWN0IGJw Zl9mdW5jX2luZm8pOw0KPj4gKwlpZiAoZW52LT5zdWJwcm9nX2NudCAhPSBuZnVuY3MpIHsNCj4+ ICsJCXZlcmJvc2UoZW52LCAibnVtYmVyIG9mIGZ1bmNzIGluIGZ1bmNfaW5mbyBkb2VzIG5vdCBt YXRjaCB2ZXJpZmllclxuIik7DQo+IA0KPiAnZG9lcyBub3QgbWF0Y2ggdmVyaWZpZXInIGlzIGhh cmQgdG8gbWFrZSBzZW5zZSBvZi4NCj4gSG93IGFib3V0ICdudW1iZXIgb2YgZnVuY3MgaW4gZnVu Y19pbmZvIGRvZXNuJ3QgbWF0Y2ggbnVtYmVyIG9mIHN1YnByb2dzJyA/DQoNClNvdW5kcyBnb29k IHRvIG1lLg0KDQo+IA0KPj4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+PiArCX0NCj4+ICsNCj4+ICsJ ZGF0YSA9IGt2bWFsbG9jKGF0dHItPmZ1bmNfaW5mb19sZW4sIEdGUF9LRVJORUwgfCBfX0dGUF9O T1dBUk4pOw0KPj4gKwlpZiAoIWRhdGEpIHsNCj4+ICsJCXZlcmJvc2UoZW52LCAibm8gbWVtb3J5 IHRvIGFsbG9jYXRlIGF0dHIgZnVuY19pbmZvXG4iKTsNCj4gDQo+IEkgZG9uJ3QgdGhpbmsgd2Ug ZXZlciBwcmludCBzdWNoIHdhcm5pbmdzIGZvciBtZW1vcnkgYWxsb2NhdGlvbnMuDQo+IGltbyB0 aGlzIGNhbiBiZSByZW1vdmVkLCBzaW5jZSBlbm9tZW0gaXMgZW5vdWdoLg0KDQpPa2F5Lg0KDQo+ IA0KPj4gKwkJcmV0dXJuIC1FTk9NRU07DQo+PiArCX0NCj4+ICsNCj4+ICsJaWYgKGNvcHlfZnJv bV91c2VyKGRhdGEsIHU2NF90b191c2VyX3B0cihhdHRyLT5mdW5jX2luZm8pLA0KPj4gKwkJCSAg IGF0dHItPmZ1bmNfaW5mb19sZW4pKSB7DQo+PiArCQl2ZXJib3NlKGVudiwgIm1lbW9yeSBjb3B5 IGVycm9yIGZvciBhdHRyIGZ1bmNfaW5mb1xuIik7DQo+IA0KPiBzaW1pbGFyIHRoaW5nLiBrZXJu ZWwgbmV2ZXIgd2FybnMgYWJvdXQgY29weV9mcm9tX3VzZXIgZXJyb3JzLg0KDQpPa2F5Lg0KDQo+ IA0KPj4gKwkJcmV0ID0gLUVGQVVMVDsNCj4+ICsJCWdvdG8gY2xlYW51cDsNCj4+ICsJCX0NCj4+ ICsNCj4+ICsJZm9yIChpID0gMDsgaSA8IG5mdW5jczsgaSsrKSB7DQo+PiArCQlpZiAoZW52LT5z dWJwcm9nX2luZm9baV0uc3RhcnQgIT0gZGF0YVtpXS5pbnNuX29mZnNldCkgew0KPj4gKwkJCXZl cmJvc2UoZW52LCAiZnVuY19pbmZvIHN1YnByb2cgc3RhcnQgKCVkKSBkb2VzIG5vdCBtYXRjaCB2 ZXJpZmllciAoJWQpXG4iLA0KPj4gKwkJCQllbnYtPnN1YnByb2dfaW5mb1tpXS5zdGFydCwgZGF0 YVtpXS5pbnNuX29mZnNldCk7DQo+IA0KPiBJIHRoaW5rIHByaW50aW5nIGV4YWN0IGluc24gb2Zm c2V0IGlzbid0IGdvaW5nIHRvIGJlIG11Y2ggaGVscA0KPiBmb3IgcmVndWxhciB1c2VyIHRvIGRl YnVnIGl0LiBJZiB0aGlzIGhhcHBlbnMsIGl0J3MgbGlrZWx5IGxsdm0gaXNzdWUuDQo+IEhvdyBh Ym91dCAnZnVuY19pbmZvIEJURiBzZWN0aW9uIGRvZXNuJ3QgbWF0Y2ggc3VicHJvZyBsYXlvdXQg aW4gQlBGIHByb2dyYW0nID8NCg0KT2theS4NCg0KPiANCg==