From: David Ahern <dsa@cumulusnetworks.com>
To: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>,
YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
rshearma@brocade.com, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next v2] net: ipv6: Fix UDP early demux lookup with udp_l3mdev_accept=0
Date: Tue, 18 Apr 2017 09:46:18 -0600 [thread overview]
Message-ID: <d2f5b51a-9cf2-d35b-2f3c-1b22f3d8b31a@cumulusnetworks.com> (raw)
In-Reply-To: <2a12c7c44ddd3e372a84db9318a40c98@codeaurora.org>
On 4/17/17 7:07 PM, Subash Abhinov Kasiviswanathan wrote:
>>> + break;
>> I think break here should remove ?
>
> Hi Yuan
>
> This is similar to __udp4_lib_demux_lookup where we need to check if the
> first
> socket is an exact match or break since chains maybe long.
>
I suggest adding the same comment as __udp4_lib_demux_lookup; it does
look odd.
next prev parent reply other threads:[~2017-04-18 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 23:24 [PATCH net-next v2] net: ipv6: Fix UDP early demux lookup with udp_l3mdev_accept=0 Subash Abhinov Kasiviswanathan
2017-04-17 23:51 ` YUAN Linyu
2017-04-18 1:07 ` Subash Abhinov Kasiviswanathan
2017-04-18 15:46 ` David Ahern [this message]
2017-04-18 15:59 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2f5b51a-9cf2-d35b-2f3c-1b22f3d8b31a@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rshearma@brocade.com \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).