From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Kwapulinski, Piotr" <piotr.kwapulinski@intel.com>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
Simon Horman <horms@kernel.org>
Cc: "intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
"pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
"Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH iwl-next v2 1/2] ixgbe: e610: Convert ACI descriptor buffer to little endian
Date: Tue, 27 Jan 2026 10:51:05 -0800 [thread overview]
Message-ID: <d3193abf-e758-4ee8-995b-72d850f99c1a@intel.com> (raw)
In-Reply-To: <BL1PR11MB597993D5BC80645017BF6F60F390A@BL1PR11MB5979.namprd11.prod.outlook.com>
On 1/27/2026 3:31 AM, Kwapulinski, Piotr wrote:
...
>>>> @@ -145,7 +146,7 @@ static int ixgbe_aci_send_cmd_execute(struct
>>> ixgbe_hw *hw,
>>>> if ((hicr & IXGBE_PF_HICR_SV)) {
>>>> for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
>>>> raw_desc[i] = IXGBE_READ_REG(hw,
>>> IXGBE_PF_HIDA(i));
>>>> - raw_desc[i] = raw_desc[i];
>>>
>>> I'm also curious to know what the intent (if any) of the line above was/is.
...
> will drop this patch,
Could we remove the raw_desc redundant assignment though? I think
there's one other instance nearby. You can send it separately and I'll
make it part of the same series as the other patch when it goes to netdev.
Thanks,
Tony
next prev parent reply other threads:[~2026-01-27 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 16:46 [PATCH iwl-next v2 1/2] ixgbe: e610: Convert ACI descriptor buffer to little endian Piotr Kwapulinski
2026-01-23 20:06 ` Simon Horman
2026-01-23 23:41 ` Keller, Jacob E
2026-01-26 11:01 ` Simon Horman
2026-01-26 20:00 ` [Intel-wired-lan] " Keller, Jacob E
2026-01-27 11:31 ` Kwapulinski, Piotr
2026-01-27 18:51 ` Tony Nguyen [this message]
2026-01-28 11:18 ` Kwapulinski, Piotr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3193abf-e758-4ee8-995b-72d850f99c1a@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotr.kwapulinski@intel.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox