From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.219.98 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792510832; b=PTdHqh2QwKe6DN7dkYsL7NNVnwfUwkOHJ1YcsAjOiyYF+ELpa+8vuoVhdTwQapHt0YZs H2B1r5fefUhQcAO5fTbGVqMJ+VCvW+MLH6VyMHG/nByaLfg+CWfECAXE+i9q4CAOkMZ0r p8phE6aCh/YmTfEYJDFFofGU6n7gRiW07ppZrUfI9OWB4YV8l4xoAsKhhEAccRefkLqFr TUsw/csMpJ3AAZAMGgoiuSbVfNIeCfBE86WKK7gzYyU1fpNzwDcKNtnQ3vTPlOAiERpdg Kipha+XmIgrIbpnIwYATqBbV0puumDbQd0JtAqHkjmxaLP5tP+tJC0jHnxjT7cO1jQw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792510832; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:X-Relaying-Domain: X-CFilter-Loop:Received:DKIM-Signature:X-Forwarded-Encrypted: X-Received:X-Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:Autocrypt: In-Reply-To:Content-Type:Content-Transfer-Encoding: X-DetectorID-Processed; bh=ML45x5sW+PAr1KGTLm2moYcZjhtqIIktLxAFW+bDKzs=; b=WdMOrQzww0QfGwXnbKRwTWtbFEtlAei089B5BRfxXU0RIEj+1FbMCRHy/A95zBj8HkXy dsryqNU2oThRC0Wew0TKtBvhtCjAVJVHmSEuyaF5feq3/MPYfcf/2ZZt+u+wzYBCLS0t1 EPV4mNkMS5mPEMC06dUa0F/XTs/LzGBOu/HSCfpDamUgRn4kLeg2fjLBxKXD0y81twsCE LpECaZRrbMrW5Z+5wrBL5PPbdmUtRl0IV4dpGJfLgVGxvCdQUjSqvLleCquWtwnMbI0wI i7pS6X+BQgSz9WFHhgoM7vBBRTAnOxR3G6niOY03MYuknlSNZimLGLjEvGwagpNg9Zw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=IZX85BI2; arc=none smtp.remote-ip=209.85.219.98 Received: from mail-qv1-f98.google.com (mail-qv1-f98.google.com [209.85.219.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3025B60A2601 for ; Tue, 20 Oct 2026 15:40:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3025B60A2601 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=IZX85BI2 Received: by mail-qv1-f98.google.com with SMTP id 6a1803df08f44-917a707f37eso33266846d6.0 for ; Tue, 20 Oct 2026 08:40:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792510831; x=1793115631; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=ML45x5sW+PAr1KGTLm2moYcZjhtqIIktLxAFW+bDKzs=; b=MT6encMOfNncGhUp8ttVUBumQSXAkJEQw9hoB95I+DIooAegHssxwQCP2ZROccTU2v BsMOQ7J7txqDRBAZClkQoQ7WRzJ7jq8WEsAJSgYObRG26bG3cfosMRTzVpip8QjQLfjb aBZYH6zVsVmIs05Gb/7KRiprDjeegx+gIIvrSGh1ydSFGjovD8330gaakkgk/Ka4xzCP /EDKFcrNppyyWztlkcXRP6cbmKNzN1/jI6k4dLedtk8DWGqYcdh/qyG+4+JahP38fxTD bdgY31yek9zxQYR795mhq1tGBPhTUX7LaS+zrsslukBxxQG3/2uaHJB2UoFgymXMnGiT QA7A== X-Forwarded-Encrypted: i=1; AKwUvByNn/88ObF1bYxJ816rHMZDJr6k8gRQcePov2dUPjiLlie9VkLQaVLYSG8kS7ZqrsJxY/NyB+c=@vger.kernel.org X-Gm-Message-State: AFq9FYIFQPN9YH0VxquaYrFqgrc59gqgxpLVmPA21xxjW+hqcXDpLqtL ARklkVQBmMLehktg1bM4g8V3jAtoY471echuEjPSBkx3XzQAoWXqEpuOEvE+YFKNTQyg2TrlJY4 tn/sN8SC5Hit+KgLGLHrVpdlzrae3HW4OKamg5zsZiCMUYFT5nnzzgG4dIxbkoS0vHeJ/WzfyN4 H/yQKc8M662qHk7MYl6RtIBdqTHT7bHx9wLMh9LPY8MQY0r23gIiOPVYsOn52GASqGlwsTWqOaF BRzvUIh+BLD7zm/ X-Gm-Gg: AYBFou0DC7mpxmJEar/psvZsSzsHSe69mFKck+yQEgXRlsmlkzvCSQOmcC2ssUP+S/h ki66f247QimQ0hR6S7YfN/+CReob3ImN9yltHuNCncMOUDwU9LOWayJbcDnJdDWMFh75saOnbOU Yl0yGvTLfbR9FIbDyBaPXbLM7ILA+vPaIJZRjPyd7/EByrIY97s3pc1mFzT8l6QaBGXVkXgkbl6 6VpM/2GUWdaAKriZpDTOH/On5wfh02I6WlciVk4MnRkC1n3KF0wieeDj9wydsWWnL7/FL/kRDnQ O6Xca3kNa4WTnq7qFUvEIukLZl1N6ovwPJQ6UlWp9lZ0btGAX1GMdUoGXPF/hWQxjRNbV772SSb 1+qCid3M/LO2330ZjhpuaNBtZAXgyeOr+AU3NSvySS/zdyAoc+5vG0pwl4KGbxUHnB19vziew+/ jHPv6RrN2c5wC/pb0cRKZjnXQRSJG9xJnXSRiZaicd X-Received: by 2002:a05:6214:5002:b0:91b:5480:ee2a with SMTP id 6a1803df08f44-91bdf0e861amr192364706d6.41.1792510830506; Tue, 20 Oct 2026 08:40:30 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-17.dlp.protect.broadcom.com. [144.49.247.17]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-91c10c24c50sm7696d6.49.2026.10.20.08.40.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2026 08:40:30 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5363b06bcb2so80998261cf.2 for ; Tue, 20 Oct 2026 08:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1792510829; x=1793115629; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ML45x5sW+PAr1KGTLm2moYcZjhtqIIktLxAFW+bDKzs=; b=IZX85BI2CjOQVXf3MfJB93CEuOCp6S0brf/Vz4Ot2DhTAnD92sQDmF+XACFN/rv0Vq 3zrQ4lASuAsEdx9ZrvWilN9ReCudYovzAfEGynw8sVAlVhS0So1Rz7q8lENdLcKNyHtC p0uDRWZeSYA0x12ppQwjIn4Y4TcOerm+bp8k0= X-Forwarded-Encrypted: i=1; AKwUvBycf34DPeMRYUITbVjMu0Av7KSkIJx4UTWXNUutN8EWptzV8FC9OL80m1mNkAuHTcefxJ7COZo=@vger.kernel.org X-Received: by 2002:a05:622a:3cc:b0:535:dd0a:c09e with SMTP id d75a77b69052e-53646083963mr164536531cf.74.1792510828714; Tue, 20 Oct 2026 08:40:28 -0700 (PDT) X-Received: by 2002:a05:622a:3cc:b0:535:dd0a:c09e with SMTP id d75a77b69052e-53646083963mr164535781cf.74.1792510828049; Tue, 20 Oct 2026 08:40:28 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-53656bcf751sm81961331cf.14.2026.10.20.08.40.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2026 08:40:27 -0700 (PDT) Message-ID: Date: Tue, 20 Oct 2026 08:40:23 -0700 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] clk: bcm2835: register the BCM2711 GISB clock To: Nicolai Buchwitz , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Stefan Wahren , Phil Elwell , netdev@vger.kernel.org, James Clark References: <20261020-devel-bcm2711-gisb-clk-v1-0-a1728724d0f8@tipi-net.de> <20261020-devel-bcm2711-gisb-clk-v1-2-a1728724d0f8@tipi-net.de> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20261020-devel-bcm2711-gisb-clk-v1-2-a1728724d0f8@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 10/20/26 07:58, Nicolai Buchwitz wrote: > The generator at CM offset 0x1d8 is not in any documentation I could > find, but the firmware calls it gisb and runs it at 200 MHz off > PLLD_PER with a 3.75 divider. GISB is the register bus of the STB > peripherals, and on BCM2711 the GENET MDIO controller clocks its MDC > from it. mdio-bcm-unimac wants that rate to work out the MDC period. > > Mark it critical. The firmware enables it at boot and nothing in Linux > owns it, so it must never be gated. > > Checked on a Raspberry Pi CM4 by moving the divider at runtime, the > MDIO busy time follows it. > > Signed-off-by: Nicolai Buchwitz Reviewed-by: Florian Fainelli > --- > drivers/clk/bcm/clk-bcm2835.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index 118df86d717c6..bc1de20c7e00e 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -117,6 +117,8 @@ > #define CM_EMMCDIV 0x1c4 > #define CM_EMMC2CTL 0x1d0 > #define CM_EMMC2DIV 0x1d4 > +#define CM_GISBCTL 0x1d8 > +#define CM_GISBDIV 0x1dc Yes, those names are correct and accurate here. -- Florian